[
https://issues.apache.org/jira/browse/LOG4J2-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544258#comment-13544258
]
Scott Severtson commented on LOG4J2-136:
----------------------------------------
Looks good, and seems to work in my tests. A couple minor nits:
1. The constant DEFAULT_CONVERSION_PATTERN is defined, but never used.
2. On line 484 of RFC5424Layout.java on trunk, we attempt to use the charset in
a logged error message, but it will only ever be null.
3. Neither of the new parameters ended up with JavaDoc entries in either
SyslogAppender or RFC5424Layout.
Thanks!
> Syslog: Optional escaping of newlines in message body, optionally include
> stack trace
> -------------------------------------------------------------------------------------
>
> Key: LOG4J2-136
> URL: https://issues.apache.org/jira/browse/LOG4J2-136
> Project: Log4j 2
> Issue Type: Improvement
> Components: Appenders, Layouts
> Affects Versions: 2.0-beta3
> Environment: N/A
> Reporter: Scott Severtson
> Assignee: Ralph Goers
> Priority: Minor
> Labels: patch
> Fix For: 2.0-beta4
>
> Attachments: syslog-escape-newlines-and-include-stack-trace.patch,
> syslog-escape-newlines.patch
>
>
> Syslog (both RFC-3164 and 5424) use newline characters to frame messages. As
> Log4J2 messages may include newlines in the message body, it is necessary to
> replace newlines with a configurable escape string.
> I've implemented a configuration option "newLineEscape" which accepts a
> replacement string. The default is to not escape newlines (i.e. current
> behavior).
> I've also implemented a configuration option "exceptionConverstion", which
> accepts the same options as PatternLayout's %exception field. If no value is
> specified, exceptions are not included.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
