[ 
https://issues.apache.org/jira/browse/LOG4J2-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553359#comment-13553359
 ] 

Scott Severtson commented on LOG4J2-149:
----------------------------------------

The patch was generated against SVN revision #1433251, and "svn update" found 
no additional changes beyond that. I compared the previously attached patch 
with a regenerated patch, and there were no differences. Not sure what you're 
seeing?
                
> SMTPManager buffer access not synchronized; can result in empty emails
> ----------------------------------------------------------------------
>
>                 Key: LOG4J2-149
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-149
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 2.0-beta4
>         Environment: N/A
>            Reporter: Scott Severtson
>         Attachments: SMTPAppender-always-log-last-event.patch, 
> SMTPManager-buffer-synchronization.patch
>
>
> If multiple error events are logged against the same SMTPAppender/Manager at 
> the same time, one email will contain both error messages, while the second 
> will be empty (no events).
> The original SMTPAppender patch included synchronization against the 
> CyclicBuffer to prevent such simultaneous access from multiple threads. This 
> appears to have been lost in the merge/refactor. Patch (to follow shortly) 
> re-introduces synchronization against the CyclicBuffer in the narrowest 
> possible scope.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to