[ 
https://issues.apache.org/jira/browse/LOG4J2-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555809#comment-13555809
 ] 

Ralph Goers commented on LOG4J2-148:
------------------------------------

I looked at this and am having a bit of trouble with it.  I don't think just 
having all the results agree is enough.  It seems strange that having all the 
results be ACCEPT and all the results being deny would both wind up returning 
the onMatch value.

Would it make sense to return onMatch if all the results are ACCEPT and 
onMismatch if they are all DENY?
                
> Enhance Composite Filter to allow for and type operation
> --------------------------------------------------------
>
>                 Key: LOG4J2-148
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-148
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Filters
>            Reporter: William Burns
>         Attachments: CompositeFilter.java, diff
>
>
> Currently the CompositeFilter only really allows for an or type of operation 
> where it returns the first result that isn't a NEUTRAL.  I found the need to 
> desire something where I want it to only return ACCEPT or DENY if all of the 
> filters say the same thing.
> The way I have it implemented it returns NEUTRAL if all of the filters cannot 
> agree, however I can see having this configurable to say DENY in the case 
> where they don't all agree.
> Let me know if you think this seems reasonable or not.
> I will attach the diff and current file I had modified.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to