[
https://issues.apache.org/jira/browse/LOG4J2-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627475#comment-13627475
]
Scott Deboy commented on LOG4J2-191:
------------------------------------
Based on our previous discussions, I made changes to Plugins to remove the
default from elementType..which results in 60 errors..suggestions on names?
And is now a good time to rename type to 'group/category'?
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/NDCPatternConverter.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/NDCPatternConverter.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
Error:Error:line (54)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java:54:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
Error:Error:line (490)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java:490:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/AppenderRef.java
Error:Error:line (31)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/AppenderRef.java:31:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/Property.java
Error:Error:line (29)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/Property.java:29:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/MapLookup.java
Error:Error:line (28)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/MapLookup.java:28:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/routing/Route.java
Error:Error:line (30)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/routing/Route.java:30:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverter.java
Error:Error:line (33)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverter.java:33:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/RegexReplacement.java
Error:Error:line (30)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/RegexReplacement.java:30:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/RootThrowablePatternConverter.java
Error:Error:line (32)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/RootThrowablePatternConverter.java:32:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/LevelPatternConverter.java
Error:Error:line (28)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/LevelPatternConverter.java:28:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/RelativeTimePatternConverter.java
Error:Error:line (27)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/RelativeTimePatternConverter.java:27:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/filter/CompositeFilter.java
Error:Error:line (39)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/filter/CompositeFilter.java:39:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/HighlightConverter.java
Error:Error:line (71)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/HighlightConverter.java:71:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/XMLConfigurationFactory.java
Error:Error:line (24)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/XMLConfigurationFactory.java:24:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/ClassNamePatternConverter.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/ClassNamePatternConverter.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/MethodLocationPatternConverter.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/MethodLocationPatternConverter.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/FileDatePatternConverter.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/FileDatePatternConverter.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/routing/Routes.java
Error:Error:line (29)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/routing/Routes.java:29:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/RegexReplacementConverter.java
Error:Error:line (30)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/RegexReplacementConverter.java:30:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/FullLocationPatternConverter.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/FullLocationPatternConverter.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/CompositeTriggeringPolicy.java
Error:Error:line (27)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/CompositeTriggeringPolicy.java:27:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java
Error:Error:line (66)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java:66:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java
Error:Error:line (28)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java:28:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/helpers/KeyValuePair.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/helpers/KeyValuePair.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/LineLocationPatternConverter.java
Error:Error:line (25)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/LineLocationPatternConverter.java:25:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/AbstractStyleNameConverter.java
Error:Error:line (53)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/AbstractStyleNameConverter.java:53:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
Error:Error:line (86)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/AbstractStyleNameConverter.java:86:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
Error:Error:line (119)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/AbstractStyleNameConverter.java:119:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
Error:Error:line (152)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/AbstractStyleNameConverter.java:152:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
Error:Error:line (185)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/AbstractStyleNameConverter.java:185:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
Error:Error:line (218)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/AbstractStyleNameConverter.java:218:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
Error:Error:line (251)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/AbstractStyleNameConverter.java:251:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
Error:Error:line (284)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/AbstractStyleNameConverter.java:284:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/MDCPatternConverter.java
Error:Error:line (33)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/MDCPatternConverter.java:33:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/IntegerPatternConverter.java
Error:Error:line (27)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/IntegerPatternConverter.java:27:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/plugins/PropertiesPlugin.java
Error:Error:line (31)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/plugins/PropertiesPlugin.java:31:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/EnvironmentLookup.java
Error:Error:line (25)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/EnvironmentLookup.java:25:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/SequenceNumberPatternConverter.java
Error:Error:line (28)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/SequenceNumberPatternConverter.java:28:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/DateLookup.java
Error:Error:line (31)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/DateLookup.java:31:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/SystemPropertiesLookup.java
Error:Error:line (25)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/SystemPropertiesLookup.java:25:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/OnStartupTriggeringPolicy.java
Error:Error:line (31)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/OnStartupTriggeringPolicy.java:31:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java
Error:Error:line (35)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java:35:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/LineSeparatorPatternConverter.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/LineSeparatorPatternConverter.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/ContextMapLookup.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/ContextMapLookup.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/ThreadPatternConverter.java
Error:Error:line (25)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/ThreadPatternConverter.java:25:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java
Error:Error:line (30)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:30:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/plugins/AppendersPlugin.java
Error:Error:line (28)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/plugins/AppendersPlugin.java:28:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/plugins/LoggersPlugin.java
Error:Error:line (28)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/plugins/LoggersPlugin.java:28:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java
Error:Error:line (32)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java:32:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/TimeBasedTriggeringPolicy.java
Error:Error:line (27)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/rolling/TimeBasedTriggeringPolicy.java:27:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/JSONConfigurationFactory.java
Error:Error:line (25)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/config/JSONConfigurationFactory.java:25:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/StyleConverter.java
Error:Error:line (29)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/StyleConverter.java:29:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/UUIDPatternConverter.java
Error:Error:line (28)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/UUIDPatternConverter.java:28:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/StructuredDataLookup.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/lookup/StructuredDataLookup.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/FailoversPlugin.java
Error:Error:line (29)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/appender/FailoversPlugin.java:29:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/MapPatternConverter.java
Error:Error:line (33)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/MapPatternConverter.java:33:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/LoggerPatternConverter.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/LoggerPatternConverter.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/FileLocationPatternConverter.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/FileLocationPatternConverter.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/MarkerPatternConverter.java
Error:Error:line (26)java:
/Users/admin/work/log4j2/core/src/main/java/org/apache/logging/log4j/core/pattern/MarkerPatternConverter.java:26:
annotation org.apache.logging.log4j.core.config.plugins.Plugin is missing
elementType
> Improve plugin uniqueness by name and type, not just name
> ---------------------------------------------------------
>
> Key: LOG4J2-191
> URL: https://issues.apache.org/jira/browse/LOG4J2-191
> Project: Log4j 2
> Issue Type: Bug
> Reporter: Scott Deboy
>
> I have a default/no-op 'advertiser' implementation:
> @Plugin(name = "default", type = "Core", elementType = "advertiser",
> printObject = false)
> public class DefaultLeftOut implements Advertiser {
> If some other person names another plugin as 'default' in core or even under
> a different 'type' (admittedly default is a terrible name and I should rename
> it)...we will have a problem.
> I think the element type should be part of the resolution..
> Still using:
> PluginManager pluginManager = new PluginManager("Core");
> pluginManager.collectPlugins();
> But instead of code using:
> PluginType type = getPluginManager().getPluginType(name);
> (with name = 'default' in this Advertiser case, giving me a DefaultAdvertiser)
> Maybe:
> PluginType type = getPluginmanager().getPluginType(elementType, name);
> (with elementType = 'advertiser' and name = 'default' in this advertiser case)
> In theory, we should also update the Maps in pluginmanager to support this
> uniqueness...right now we collide just on 'name' in the type.
> Right now, the last one wins, which isn't ideal.
> At least we'd reduce the likelihood of collisions.
> Along with passing in type type and name in the lookup, collisions of name
> and type (another 'default' in 'core') should be logged at warn level. I
> suppose last one registered should still win.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
