[
https://issues.apache.org/jira/browse/LOG4J2-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653360#comment-13653360
]
Nick Williams commented on LOG4J2-248:
--------------------------------------
I don't think PMD is used to web applications and the five hundred (read:
exaggeration) different class loaders they can have. I'm fairly certain this
code is correct as-is. I'm pretty sure we just need to suppress that warning.
> Log4jContextListener: Use Thread instead of Class for fallback classloader
> --------------------------------------------------------------------------
>
> Key: LOG4J2-248
> URL: https://issues.apache.org/jira/browse/LOG4J2-248
> Project: Log4j 2
> Issue Type: Improvement
> Affects Versions: 2.0-beta5
> Reporter: Tim Tucker
> Priority: Minor
>
> I was experimenting with creating my own context listener based on
> Log4jContextListener and noticed that the call in getClassLoader to get the
> class's classloader was triggering a PMD warning.
> The rule's notes indicate that Thread.currentThread().getContextClassLoader()
> might return more reliable results than Object.class.getClassLoader().
> The code in question is as follows:
> try {
> // if container is Servlet 3.0, use its getClassLoader method
> return
> (ClassLoader)context.getClass().getMethod("getClassLoader").invoke(context);
> } catch (Exception ignore) {
> // otherwise, use this class's class loader
> return Log4jContextListener.class.getClassLoader();
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
