So... blow them away? Gary
On Fri, Jun 14, 2013 at 10:08 AM, Gary Gregory <[email protected]>wrote: > As far as I can tell they are not used. Is it possible that they can be > refereed to and used from a config file? I am guessing not otherwise I'd > find a reference to the Filter class in our code somewhere... > > Gary > > > On Fri, Jun 14, 2013 at 9:19 AM, Ralph Goers > <[email protected]>wrote: > >> But where are any of the classes that implement that Filter interface >> ever used? I think they should just be deleted. >> >> Ralph >> >> On Jun 14, 2013, at 6:11 AM, Gary Gregory wrote: >> >> org.apache.logging.log4j.core.util.Compare is used from >> org.apache.logging.log4j.core.layout.PatternLayoutTest.mdcPattern() >> >> org.apache.logging.log4j.core.util.Profiler is used from >> >> org.apache.logging.log4j.DebugDisabledPerformanceComparison.testPerformance() >> org.apache.logging.log4j.PerformanceComparison.testPerformance() >> >> org.apache.logging.log4j.core.util.UnexpectedFormatException is used >> withing the same package. >> >> org.apache.logging.log4j.core.util.Filter is used withing the same >> package. >> >> Gary >> >> >> On Fri, Jun 14, 2013 at 8:57 AM, Ralph Goers <[email protected]> wrote: >> >>> What tests? I didn't search but since they are not plugins I am not sure >>> what could use them. >>> >>> Sent from my iPad >>> >>> On Jun 14, 2013, at 5:53 AM, Gary Gregory <[email protected]> >>> wrote: >>> >>> All of the code in this package in a the test source folder is only used >>> by tests. It is interesting that it never made it over to the production >>> code side. Maybe that is an omission. I'm not sure if those classes are >>> supposed to be loaded by name (Class.forName()) from the guts of Log4j. I >>> am guessing not since the Filter interface is not used outside this package. >>> >>> Gary >>> >>> >>> On Fri, Jun 14, 2013 at 2:10 AM, Ralph Goers <[email protected]> wrote: >>> >>>> Which in turn are used by what? >>>> >>>> Sent from my iPad >>>> >>>> On Jun 13, 2013, at 7:13 PM, Gary Gregory <[email protected]> >>>> wrote: >>>> >>>> Actually, it is used in all of these: >>>> >>>> AbsoluteDateAndTimeFilter.java >>>> AbsoluteTimeFilter.java >>>> ControlFilter.java >>>> ISO8601Filter.java >>>> JunitTestRunnerFilter.java >>>> LineNumberFilter.java >>>> RelativeTimeFilter.java >>>> SunReflectFilter.java >>>> >>>> Gary >>>> >>>> >>>> On Thu, Jun 13, 2013 at 7:34 PM, Gary Gregory >>>> <[email protected]>wrote: >>>> >>>>> ORO is used in >>>>> https://svn.apache.org/repos/asf/logging/log4j/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/util/AbsoluteDateAndTimeFilter.java >>>>> >>>>> Gary >>>>> >>>>> >>>>> On Thu, Jun 13, 2013 at 7:32 PM, Ralph Goers < >>>>> [email protected]> wrote: >>>>> >>>>>> I don't recall coding anything that uses ORO. Where is it being used? >>>>>> In those same classes? >>>>>> >>>>>> Ralph >>>>>> >>>>>> On Jun 13, 2013, at 4:29 PM, Gary Gregory wrote: >>>>>> >>>>>> We could at least use Java RE's instead of ORO... yes? >>>>>> >>>>>> Gary >>>>>> >>>>>> >>>>>> On Thu, Jun 6, 2013 at 1:19 PM, Ralph Goers < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> I was wondering that myself. In fact, it is sitting in a directory >>>>>>> with a bunch of other classes that I don't think are used, all of which >>>>>>> implement org.apache.logging.log4j.core.util.Filter. I think the whole >>>>>>> util directory was brought in for the log4j 1.x testing. I have a >>>>>>> suspicion that only Compare.java and Profiler.java are actually being >>>>>>> used >>>>>>> by anything. >>>>>>> >>>>>>> Ralph >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Jun 6, 2013, at 9:16 AM, Gary Gregory wrote: >>>>>>> >>>>>>> Can we get rid of >>>>>>> org.apache.logging.log4j.core.util.SunReflectFilter? >>>>>>> >>>>>>> How is it used? >>>>>>> >>>>>>> If we keep it, we could at least JRE APIs and drop the ORO dep. >>>>>>> >>>>>>> Gary >>>>>>> >>>>>>> -- >>>>>>> E-Mail: [email protected] | [email protected] >>>>>>> Java Persistence with Hibernate, Second >>>>>>> Edition<http://www.manning.com/bauer3/> >>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>>> Blog: http://garygregory.wordpress.com >>>>>>> Home: http://garygregory.com/ >>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> E-Mail: [email protected] | [email protected] >>>>>> Java Persistence with Hibernate, Second >>>>>> Edition<http://www.manning.com/bauer3/> >>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>> Blog: http://garygregory.wordpress.com >>>>>> Home: http://garygregory.com/ >>>>>> Tweet! http://twitter.com/GaryGregory >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> E-Mail: [email protected] | [email protected] >>>>> Java Persistence with Hibernate, Second >>>>> Edition<http://www.manning.com/bauer3/> >>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>> Blog: http://garygregory.wordpress.com >>>>> Home: http://garygregory.com/ >>>>> Tweet! http://twitter.com/GaryGregory >>>>> >>>> >>>> >>>> >>>> -- >>>> E-Mail: [email protected] | [email protected] >>>> Java Persistence with Hibernate, Second >>>> Edition<http://www.manning.com/bauer3/> >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>> Spring Batch in Action <http://www.manning.com/templier/> >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>>> >>>> >>> >>> >>> -- >>> E-Mail: [email protected] | [email protected] >>> Java Persistence with Hibernate, Second >>> Edition<http://www.manning.com/bauer3/> >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>> Spring Batch in Action <http://www.manning.com/templier/> >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >>> >>> >> >> >> -- >> E-Mail: [email protected] | [email protected] >> Java Persistence with Hibernate, Second >> Edition<http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> >> >> > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second > Edition<http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
