[ https://issues.apache.org/jira/browse/LOG4J2-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757865#comment-13757865 ]
Tibor Benke commented on LOG4J2-355: ------------------------------------ Hi Gary, I think, we won't need anymore the getId(StructuredDataId) method, so you can remove it. It's functionality partially implemented in the LoggerFields class. On the other hand, as far as I can see we used the eventPrefix to mark all key-value pairs in a StructuredDataMessage. I forgot to reimplement this during the partial refactor, but after all, I think there is a better solution. Now, you can create a new SD-Element from a StructuredDataMessage, which is IMHO a more elegant way to "prefix" our key-value pairs. But, it's easy to use the eventPrefix again. What do you think about it? P.S: for demonstrating the behaviour what I described above, I'm going to upload a new testcase to RFC5424LayoutTest.java. Best wishes, Tibor > Add support for multiple SD-ELEMENTs in a RFC 5424 syslog message > ----------------------------------------------------------------- > > Key: LOG4J2-355 > URL: https://issues.apache.org/jira/browse/LOG4J2-355 > Project: Log4j 2 > Issue Type: Improvement > Components: Core > Affects Versions: 2.0-beta9 > Reporter: Tibor Benke > Fix For: 2.0-beta9 > > Attachments: add_multime_SD_ELEMENT_support.diff, > LOG4J2-355_v2.patch, LOG4J2-355_v3.patch, LOG4J2-355_v4.patch > > > The patch contains the modifications to support the feature and I also > refactored some code in the RFC5424Layout.java file. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org