I could create one for this if you like. Any particular name you want? Or is "feature/caller-info" good?
Matt Sicker > On Mar 4, 2014, at 8:13, Bruce Brouwer <[email protected]> wrote: > > I can create a JIRA. I don't think I have rights to create a branch, do I? > >> On Mar 4, 2014 8:48 AM, "Gary Gregory" <[email protected]> wrote: >> Hi Bruce, >> >> Can you create a JIRA and attach your code there? I think it will make it >> easier to track. Or better yet, create a branch if you think the experiment >> will be long lived enough. >> >> Gary >> >> >>> On Tue, Mar 4, 2014 at 8:26 AM, Bruce Brouwer <[email protected]> >>> wrote: >>> There are a number of JIRAs out there that have issues related to making >>> sure we get the correct caller location logged. I'm attaching a patch which >>> is in no way complete but demonstrates an idea that might make it easier to >>> extend loggers. For example, this makes the slf4j-impl quite a bit simpler. >>> It also impacts the jcl code, which I don't think was working to record the >>> caller location. >>> >>> The idea is to create a LoggerExtension from the original logger which >>> simply remembers the FQCN that will ultimately be the extension. Also by >>> doing this, we can switch a bunch of methods that ended up being public >>> back to protected. I'm guessing they became public so extensions could call >>> them. >>> >>> I also like how extensions (such as slf4j, jcl, custom extensions, logger >>> streams) don't have to pass in the FQCN to that special log method anymore. >>> Also, you don't have to wrap every extended log method with a check to see >>> if the logging is enabled. Finally, you don't need to have any access to >>> the MessageFactory. >>> >>> This is very much a work in progress, but please take a look (but don't >>> commit it as is) and give me your thoughts. I think it could help with some >>> of the issues we've been seeing. But if it is too much >>> >>> -- >>> >>> Bruce Brouwer >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >> >> >> >> -- >> E-Mail: [email protected] | [email protected] >> Java Persistence with Hibernate, Second Edition >> JUnit in Action, Second Edition >> Spring Batch in Action >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory
