[
https://issues.apache.org/jira/browse/LOG4J2-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947551#comment-13947551
]
Matt Sicker commented on LOG4J2-498:
------------------------------------
I've updated one unit test so far as well as added documentation about how one
might use the test rule. I'll be going through various test classes and
updating them to use the rule instead of abusing system properties (except for
any unit tests for explicitly testing configuration via system properties, of
course).
> Update unit tests to use Log4jConfig rule.
> ------------------------------------------
>
> Key: LOG4J2-498
> URL: https://issues.apache.org/jira/browse/LOG4J2-498
> Project: Log4j 2
> Issue Type: Sub-task
> Components: Core
> Affects Versions: 2.0-rc1
> Reporter: Matt Sicker
> Assignee: Matt Sicker
> Labels: JUnit, Testing
>
> Every test that duplicates the following code (or some variant):
> {code:java}
> System.setProperty(ConfigurationFactory.CONFIGURATION_FILE_PROPERTY,
> "config-file.xml");
> {code}
> Along with retrieving the updated LoggerContext, resetting StatusLogger,
> etc., can all be cleaned up by using the Log4jConfig rule. There is one
> catch, however, that I've noticed in several tests. Where a log file is
> created and deleted for a test, many tests call {{file.delete()}} at the
> beginning of the test. This is done because the logger context is retrieved
> after the call, but the rule sets up the logger context before the test is
> executed. Thus, these calls should be eliminated while leaving the
> {{file.delete()}} at the end of the test method.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
