So in this case equalsIgnoreCase can just be isEmpty(). ---------- Forwarded message ---------- From: <ggreg...@apache.org> Date: 13 May 2014 10:31 Subject: svn commit: r1594247 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java To: comm...@logging.apache.org
Author: ggregory Date: Tue May 13 15:31:14 2014 New Revision: 1594247 URL: http://svn.apache.org/r1594247 Log: Refactor magic strings into a constant. Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java?rev=1594247&r1=1594246&r2=1594247&view=diff ============================================================================== --- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java (original) +++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java Tue May 13 15:31:14 2014 @@ -28,6 +28,7 @@ import org.apache.logging.log4j.core.con import org.apache.logging.log4j.core.config.plugins.PluginAttribute; import org.apache.logging.log4j.core.config.plugins.PluginFactory; import org.apache.logging.log4j.status.StatusLogger; +import org.apache.logging.log4j.util.Strings; /** * @@ -133,7 +134,7 @@ public class SizeBasedTriggeringPolicy i // Get units specified final String units = matcher.group(3); - if (units.equalsIgnoreCase("")) { + if (units.equalsIgnoreCase(Strings.EMPTY)) { return value; } else if (units.equalsIgnoreCase("K")) { return value * KB; -- Matt Sicker <boa...@gmail.com>
