I think I named it in the first place but was too hasty, it s not like it's been like that for years! ;)
Gary <div>-------- Original message --------</div><div>From: Ralph Goers <[email protected]> </div><div>Date:05/17/2014 01:34 (GMT-05:00) </div><div>To: Log4J Developers List <[email protected]> </div><div>Subject: Re: svn commit: r1594370 - in /logging/log4j/log4j2/trunk: log4j-1.2-api/src/main/java/org/apache/log4j/ log4j-1.2-api/src/test/java/org/apache/log4j/ log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ log4j-core/src/main/java/org/apache/logging/... </div><div> </div> On May 15, 2014, at 9:09 AM, Gary Gregory <[email protected]> wrote: On Wed, May 14, 2014 at 3:16 AM, Ralph Goers <[email protected]> wrote: On May 13, 2014, at 1:26 PM, [email protected] wrote: > Author: ggregory > Date: Tue May 13 20:26:31 2014 > New Revision: 1594370 > > URL: http://svn.apache.org/r1594370 > Log: > Rename org.apache.logging.log4j.core.util.Constants.LINE_SEP to LINE_SEPARATOR Why? Do you think someone won't know what LINE_SEP is? Did you even read the guidelines I proposed last week? In general, I shy away from abbreviations unless they are standard like "XML". Gary Unless we have a guideline that says using abbreviations aren’t allowed as names unless they are “standard” please don’t go renaming them to suit your personal preference. Ralph
