Not related to this problem, but don't we have a CI in place?
If not, we should consider to get some help rom Jenkins.
On 18 May 2014, at 7:36, Ralph Goers wrote:
in some circumstances ThrowableProxy was setting the suppressed proxy
to an empty list. In another case it was setting it to null. I
changed that case to set it to an empty list to fix ThrowableProxyTest
JSONLayoutTest and XMLLayoutTest were also failing because they were
checking for a suppressed exception. However, Throwables.addSuppressed
is a noon on Java6 so no suppressed exceptions were being added. I
made the check conditional on getSuppressed being present.
Ralph
On May 17, 2014, at 9:50 PM, Ralph Goers <[email protected]>
wrote:
I’ve found the problem. It should be failing for everyone. After I
verify the fix I will check it in.
Ralph
On May 17, 2014, at 8:42 PM, Matt Sicker <[email protected]> wrote:
But I can confirm the same five tests fail for me, too, on JDK6.
On 17 May 2014 22:35, Matt Sicker <[email protected]> wrote:
Those error messages are some of the most unhelpful test failures
I've seen in a long time!
On 17 May 2014 21:42, Ralph Goers <[email protected]>
wrote:
After running in the debugger I am guessing that this is failing
because I am using Java 6 to compile and test.
this.suppressedProxies is null while other.suppressedProxies is not.
SuppressedExceptions don’t exist in Java 6 so I’m not sure why
there would be any suppressed proxies.
Ralph
On May 17, 2014, at 7:31 PM, Ralph Goers
<[email protected]> wrote:
I just did a clean checkout and log4j-core fails with the following
unit test failures on my machine.
RollingAppenderTimeTest.testAppender:76 No compressed files found
ThrowableProxyTest.testJsonIoContainer:52 expected:
org.apache.logging.log4j.core.impl.ThrowableProxy<java.io.IOException:
test> but was:
org.apache.logging.log4j.core.impl.ThrowableProxy<java.io.IOException:
test>
JSONLayoutTest.testLocationOnCompactOnMdcOn:269->testAllFeatures:116
expected:
org.apache.logging.log4j.core.impl.ThrowableProxy<java.io.IOException:
testIOEx> but was:
org.apache.logging.log4j.core.impl.ThrowableProxy<java.io.IOException:
testIOEx>
JSONLayoutTest.testLocationOffCompactOffMdcOff:264->testAllFeatures:116
expected:
org.apache.logging.log4j.core.impl.ThrowableProxy<java.io.IOException:
testIOEx> but was:
org.apache.logging.log4j.core.impl.ThrowableProxy<java.io.IOException:
testIOEx>
XMLLayoutTest.testLocationOnCompactOnMdcOn:271->testAllFeatures:131
expected:
org.apache.logging.log4j.core.impl.ThrowableProxy<java.io.IOException:
testIOEx> but was:
org.apache.logging.log4j.core.impl.ThrowableProxy<java.io.IOException:
testIOEx>
XMLLayoutTest.testLocationOffCompactOffMdcOff:266->testAllFeatures:131
expected:
org.apache.logging.log4j.core.impl.ThrowableProxy<java.io.IOException:
testIOEx> but was:
org.apache.logging.log4j.core.impl.ThrowableProxy<java.io.IOException:
testIOEx>
--
Matt Sicker <[email protected]>
--
Matt Sicker <[email protected]>
---
http://www.grobmeier.de
The Zen Programmer: http://bit.ly/12lC6DL
@grobmeier
GPG: 0xA5CC90DB
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
