OK, I'll do that then. Gary
On Thu, May 22, 2014 at 2:08 AM, Ralph Goers <[email protected]> wrote: > Makes sense to me. > > Sent from my iPad > > On May 21, 2014, at 11:05 PM, Gary Gregory <[email protected]> wrote: > > I recently added SecureSocketAppender > > Looking closely, you'll see that the only real difference between > SecureSocketAppender and SocketAppender is that SecureSocketAppender has > one additional parameter: SslConfiguration. > > Another small difference is the SecureSocketAppender only has one legal > value for protocol now: "TLS". > > So why not simply add an SslConfiguration parameter to SocketAppender with > a null default value and remove SecureSocketAppender? If the user specifies > a SslConfiguration, we use it, if not it's a plan TCP or UDP socket. > > If the user passes both UPD and an SslConfiguration, that's an > IllegalArgumentException. > > The same pattern applies to SyslogAppender and TlsSyslogAppende. > > Thoughts? > > Gary > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second > Edition<http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
