Indeed.
On 3 June 2014 19:18, Ralph Goers <[email protected]> wrote: > Similar to why I created @ConverterKeys for pattern converters I guess? > That sounds correct. > > Ralph > > On Jun 3, 2014, at 5:07 PM, Matt Sicker <[email protected]> wrote: > > I changed my mind on that and am adding a @ConvertType annotation that > will be scanned at runtime. No changes to @Plugin or the annotation > processor this way, too. > > > On 3 June 2014 19:05, Ralph Goers <[email protected]> wrote: > >> Why would you add a class attribute when the annotation is annotating the >> class and you can get it from that? >> >> Ralph >> >> On Jun 3, 2014, at 4:50 PM, [email protected] wrote: >> >> > Author: mattsicker >> > Date: Tue Jun 3 23:50:29 2014 >> > New Revision: 1599839 >> > >> > URL: http://svn.apache.org/r1599839 >> > Log: >> > Revert that idea about the default name. >> > >> > - Going to add an optional Class attribute instead. >> > >> > Modified: >> > >> >> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/Plugin.java >> > >> > Modified: >> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/Plugin.java >> > URL: >> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/Plugin.java?rev=1599839&r1=1599838&r2=1599839&view=diff >> > >> ============================================================================== >> > --- >> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/Plugin.java >> (original) >> > +++ >> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/Plugin.java >> Tue Jun 3 23:50:29 2014 >> > @@ -38,10 +38,9 @@ public @interface Plugin { >> > String EMPTY = Strings.EMPTY; >> > >> > /** >> > - * Name of the plugin. If no name is specified, defaults to the >> simple class name of the annotated element. >> > - * Note that this name is case-insensitive. >> > + * Name of the plugin. Note that this name is case-insensitive. >> > */ >> > - String name() default EMPTY; >> > + String name(); >> > >> > /** >> > * Category to place the plugin under. Category names are >> case-sensitive. >> > >> > >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > > -- > Matt Sicker <[email protected]> > > > -- Matt Sicker <[email protected]>
