[
https://issues.apache.org/jira/browse/LOG4J2-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mck SembWever updated LOG4J2-673:
---------------------------------
Attachment: 0001-LOG4J2-673-plugin-preloading-fails-in-shaded-jar-fil.patch
New patch.
- uses Collections.list(..) in PluginManager.preloadResources(..)
- keeps the default .dat file for log4j2-core with the same name as before,
(that fixed a number of tests)
- added {{packages="org.apache.logging.log4j"}} to all test log configs that
use test plugins,
(that fixed the remaining tests)
> plugin preloading fails in shaded jar files
> -------------------------------------------
>
> Key: LOG4J2-673
> URL: https://issues.apache.org/jira/browse/LOG4J2-673
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0-rc2
> Reporter: Mck SembWever
> Priority: Critical
> Labels: annotations, compiler, plugins
> Fix For: 2.0-rc2
>
> Attachments:
> 0001-LOG4J2-673-plugin-preloading-fails-in-shaded-jar-fil.patch
>
>
> Support for plugin preloading through the standard
> javax.annotation.processing tool was adding in LOG4J2-595
> But the plugin processor always creates and stores the processed "Plugin"
> annotated classes into the same file. This works fine when the classpath
> consists of individual jar files, but fails when shaded jar files are used.
> A tested fix exists at
> https://github.com/finn-no/logging-log4j2/tree/bugfix/LOG4J2-673
> There's also a github pull request and a manual diff attached. (I can clean
> up anything not used afterwards)
> The fix saves the dat file in a location under META-INF that matches the
> shared package all the processed plugins are found under.
> The package attribute in the config file is then used so that multiple dat
> files can be loaded at runtime.
> This means that the package attribute is no longer deprecated.
> This has been tested against
> https://github.com/finn-no/log4j2-logstash-jsonevent-layout
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
