Sounds good. Immutability should be the default way of doing things anyhow.
On 25 June 2014 10:24, Gary Gregory <garydgreg...@gmail.com> wrote: > Hi All: > > The method > org.apache.logging.log4j.core.layout.PatternLayout.setConversionPattern(String) > should not exist. It is only used in one test and forces some PL state to > be mutable. > > I applied a fix for https://issues.apache.org/jira/browse/LOG4J2-682 that > exacerbates the problem by making another ivar mutable. > > I think the test should be refactored/rewritten to make the API > unnecessary. This will let the PL class be immutable. > > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- Matt Sicker <boa...@gmail.com>
