Crap, that does actually make things more complicated! It's almost getting to the point where bytecode manipulation is starting to sound like a decent idea at times.
On 8 July 2014 20:56, Gary Gregory <[email protected]> wrote: > Hm... if the error logging takes place in the plugin framework, then it > should be removed from the create() methods, but then apps that do > programmatic configuration will not benefit from the error logging. We > would then need to either keep the current guard clauses (with no logging) > or remove the guard clauses and let the chips fall where they may with NPEs. > > Thoughts? > > Gary > > > On Mon, Jul 7, 2014 at 11:35 AM, Gary Gregory <[email protected]> > wrote: > >> Why don't we have a required flag? >> >> Using it and throwing an Exception when this condition is violated would >> avoid guard code like: >> >> @PluginFactory >> public static RegexFilter createFilter( >> @PluginAttribute("regex") final Pattern regex, >> @PluginAttribute("useRawMsg") final Boolean useRawMsg, >> @PluginAttribute("onMatch") final Result match, >> @PluginAttribute("onMismatch") final Result mismatch) { >> >> if (regex == null) { >> LOGGER.error("A regular expression must be provided for >> RegexFilter"); >> return null; >> } >> return new RegexFilter(useRawMsg, regex, match, mismatch); >> } >> >> ? >> >> -- >> E-Mail: [email protected] | [email protected] >> Java Persistence with Hibernate, Second Edition >> <http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- Matt Sicker <[email protected]>
