[
https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060801#comment-14060801
]
Remko Popma commented on LOG4J2-609:
------------------------------------
Bruce, I've taken a look at the LOG4J2-609 branch.
I like the simplification of removing StatusConsoleListener.
Some comments/questions:
# Why remove the getStatusLevel() method from StatusListener? Your comment
above mentions moving it to a parameter on StatusLogger.registerListener(...)
but in the branch the whole concept of StatusListeners only receiving log
events at the level they're interested in has been removed. Can you explain why
you want to do this?
# I'm not sure adding a Marker field to the StatusData is a good idea: aren't
Markers intended to allow more sophisticated processing (filtering, triggering)
of log events? I don't think they are appropriate for use by the StatusLogger
(which is kind of deliberately not sophisticated). Note that no StatusLogger
client code currently specifies a Marker parameter. So I don't see what we gain
by adding this field, but we do change the serialized form of StatusData, which
does not seem like a good trade-off to me. (But I'm open to counter arguments.)
> StatusConfiguration doesn't close files
> ---------------------------------------
>
> Key: LOG4J2-609
> URL: https://issues.apache.org/jira/browse/LOG4J2-609
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0-rc1
> Reporter: Bruce Brouwer
> Assignee: Ralph Goers
> Attachments: LOG4J2-609.unfinished.patch, log4j2-609.patch
>
>
> {{org.apache.logging.log4j.core.config.status.StatusConfiguration}} allows
> you to specify a destination such as "out", "err" or a file name. If
> specifying a file, that file stream is used when creating a
> {{StatusConsoleListener}} that is added to the {{StatusLogger}}. Those
> {{StatusLogger}} listeners are never cleaned up when, for example, the
> {{XmlConfiguration}} is reconfigured or when the {{LoggerContext}} is shut
> down (e.g. in {{InitialLoggerContext.apply()}}). This leaves open file
> handles and is the source of the failing test {{FileOutputTest}} on Windows.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
