[
https://issues.apache.org/jira/browse/LOG4J2-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105448#comment-14105448
]
Romain Manni-Bucau commented on LOG4J2-658:
-------------------------------------------
About fragile comment: yes and no. Something to keep in mind when releasing but
while it supports API breakage it is fine IMHO.
I'm 100% ok with unregister method while I don't have to spend time learning
how to setup my login ie alternative is point 3) which means integrate with all
potential environments as automatically as possible. What should absolutely be
avoided is to ask the user to do it IMHO - typically in a container you can't
do it without hacking yourself the listener/container hook which would be a
failure.
About shutdown logic I think we should provide it since that's a quick win for
all platforms with a try {} catch(Throwable) {runtime.addShutdownHook()} as
fallback if api broke again in future version logging an info or warn message
saying "using standard shutdown hook since this jvm version xx.yy doesn't have
xx method".
> shutdown hook called too early
> ------------------------------
>
> Key: LOG4J2-658
> URL: https://issues.apache.org/jira/browse/LOG4J2-658
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0-rc1, 2.0-rc2, 2.0.2
> Reporter: Romain Manni-Bucau
> Assignee: Matt Sicker
>
> Hi
> this issue follow few mail exchanges from the commons list. Here the
> interesting part for log4j2:
> {quote}
> Here what I do (we can move it to another thread since that's 100% log4j2
> related): unzip apache-tomee-1.7.0-SNAPSHOT-webprofile.zip && cd
> apache-tomee-webprofile-1.7.0-SNAPSHOT/ && rm conf/logging.properties &&
> echo 'openejb.log.factory=log4j'>conf/system.properties && cp ~/log4j2.xml
> conf/log4j2.xml && cp
> ~/.m2/repository/org/apache/logging/log4j/log4j-api/2.0-rc2-SNAPSHOT/log4j-api-2.0-rc2-SNAPSHOT.jar
> lib/ && cp
> ~/.m2/repository/org/apache/logging/log4j/log4j-core/2.0-rc2-SNAPSHOT/log4j-core-2.0-rc2-SNAPSHOT.jar
> lib/ && cp
> ~/.m2/repository/org/apache/logging/log4j/log4j-1.2-api/2.0-rc2-SNAPSHOT/log4j-1.2-api-2.0-rc2-SNAPSHOT.jar
> lib/ && ./bin/catalina.sh
> it makes server starting with log4j2 logs, if you ctrl+c logs are not
> printed. Sure it is cause context is closed too early and then loggers have
> NullConfiguration. (If I debug in java.lang.ApplicationShutdownHooks#runHooks
> to wait all hooks exec it works)
> {quote}
> Basically the issue is that when shutting down with ctrl+C some logs are
> swallowed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
