Agreed. Just gotta configure rat I guess? On 4 October 2014 17:13, Gary Gregory <[email protected]> wrote:
> Would it be better to make the build fail if the license header is > missing? This would catch these errors earlier. > > Gary > > ---------- Forwarded message ---------- > From: <[email protected]> > Date: Sat, Oct 4, 2014 at 6:06 PM > Subject: [2/2] git commit: Add license headers. > To: [email protected] > > > Add license headers. > > > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo > Commit: > http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/ef23c80d > Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/ef23c80d > Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/ef23c80d > > Branch: refs/heads/master > Commit: ef23c80d78ac2f325310625f52ae6812bab62ac0 > Parents: 6b532ed > Author: Matt Sicker <[email protected]> > Authored: Sat Oct 4 17:06:01 2014 -0500 > Committer: Matt Sicker <[email protected]> > Committed: Sat Oct 4 17:06:01 2014 -0500 > > ---------------------------------------------------------------------- > .../log4j/core/async/AsyncRootReloadTest.java | 16 ++++++++++++++++ > .../core/util/KeyValuePairSerializationTest.java | 18 +++++++++++++++++- > .../apache/logging/log4j/io/IoBuilderTest.java | 16 ++++++++++++++++ > .../logging/log4j/io/LoggerFilterWriterTest.java | 16 ++++++++++++++++ > .../log4j/io/LoggerPrintWriterJdbcH2Test.java | 16 ++++++++++++++++ > 5 files changed, 81 insertions(+), 1 deletion(-) > ---------------------------------------------------------------------- > > > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ef23c80d/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncRootReloadTest.java > ---------------------------------------------------------------------- > diff --git > a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncRootReloadTest.java > b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncRootReloadTest.java > index 123cfe6..03fb423 100644 > --- > a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncRootReloadTest.java > +++ > b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncRootReloadTest.java > @@ -1,3 +1,19 @@ > +/* > + * Licensed to the Apache Software Foundation (ASF) under one or more > + * contributor license agreements. See the NOTICE file distributed with > + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache license, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > + * See the license for the specific language governing permissions and > + * limitations under the license. > + */ > package org.apache.logging.log4j.core.async; > > import java.io.File; > > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ef23c80d/log4j-core/src/test/java/org/apache/logging/log4j/core/util/KeyValuePairSerializationTest.java > ---------------------------------------------------------------------- > diff --git > a/log4j-core/src/test/java/org/apache/logging/log4j/core/util/KeyValuePairSerializationTest.java > b/log4j-core/src/test/java/org/apache/logging/log4j/core/util/KeyValuePairSerializationTest.java > index 9ec89d7..0893aed 100644 > --- > a/log4j-core/src/test/java/org/apache/logging/log4j/core/util/KeyValuePairSerializationTest.java > +++ > b/log4j-core/src/test/java/org/apache/logging/log4j/core/util/KeyValuePairSerializationTest.java > @@ -1,3 +1,19 @@ > +/* > + * Licensed to the Apache Software Foundation (ASF) under one or more > + * contributor license agreements. See the NOTICE file distributed with > + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache license, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > + * See the license for the specific language governing permissions and > + * limitations under the license. > + */ > package org.apache.logging.log4j.core.util; > > import java.io.Serializable; > @@ -12,7 +28,7 @@ public class KeyValuePairSerializationTest extends > AbstractSerializationTest { > @Parameters > public static Collection<Object[]> data() { > return Arrays.asList(new Object[][] { > - { new KeyValuePair("testuser", "DEBUG") }, > + { new KeyValuePair("testuser", "DEBUG") }, > { new KeyValuePair("JohnDoe", "warn") } }); > } > > > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ef23c80d/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/IoBuilderTest.java > ---------------------------------------------------------------------- > diff --git > a/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/IoBuilderTest.java > b/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/IoBuilderTest.java > index 2b1757a..303ecbb 100644 > --- > a/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/IoBuilderTest.java > +++ > b/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/IoBuilderTest.java > @@ -1,3 +1,19 @@ > +/* > + * Licensed to the Apache Software Foundation (ASF) under one or more > + * contributor license agreements. See the NOTICE file distributed with > + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache license, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > + * See the license for the specific language governing permissions and > + * limitations under the license. > + */ > package org.apache.logging.log4j.io; > > import java.io.PrintStream; > > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ef23c80d/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/LoggerFilterWriterTest.java > ---------------------------------------------------------------------- > diff --git > a/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/LoggerFilterWriterTest.java > b/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/LoggerFilterWriterTest.java > index 5ca48c6..3ccd311 100644 > --- > a/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/LoggerFilterWriterTest.java > +++ > b/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/LoggerFilterWriterTest.java > @@ -1,3 +1,19 @@ > +/* > + * Licensed to the Apache Software Foundation (ASF) under one or more > + * contributor license agreements. See the NOTICE file distributed with > + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache license, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > + * See the license for the specific language governing permissions and > + * limitations under the license. > + */ > package org.apache.logging.log4j.io; > > import java.io.StringWriter; > > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ef23c80d/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/LoggerPrintWriterJdbcH2Test.java > ---------------------------------------------------------------------- > diff --git > a/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/LoggerPrintWriterJdbcH2Test.java > b/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/LoggerPrintWriterJdbcH2Test.java > index 8c1786f..c6e6ea9 100644 > --- > a/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/LoggerPrintWriterJdbcH2Test.java > +++ > b/log4j-iostreams/src/test/java/org/apache/logging/log4j/io/LoggerPrintWriterJdbcH2Test.java > @@ -1,3 +1,19 @@ > +/* > + * Licensed to the Apache Software Foundation (ASF) under one or more > + * contributor license agreements. See the NOTICE file distributed with > + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache license, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > + * See the license for the specific language governing permissions and > + * limitations under the license. > + */ > package org.apache.logging.log4j.io; > > import java.io.PrintWriter; > > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- Matt Sicker <[email protected]>
