[
https://issues.apache.org/jira/browse/LOG4J2-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma updated LOG4J2-985:
-------------------------------
Description:
For the same reasons as LOG4J2-891 was raised, {{equals()}} and {{hashCode()}}
should be removed from {{AbstractFilter}}.
Similar to the approach for {{AbstractFilter}} I will keep the existing
implementation of equals() and rename it {{equalsImpl()}} (with the call to
{{super.equals(obj)}} replaced by {{super.equalsImpl(obj)}}).
Similarly for hashCode() to {{hashCodeImpl()}}. The xxxImpl() methods will be
protected, similar to the approach taken in {{AbstractFilter}}.
was:
For the same reasons as LOG4J2-891 was raised, {{equals()}} and {{hashCode()}}
should be removed from {{AbstractFilter}}.
> AbstractFilter should not implement equals() and hashCode()
> -----------------------------------------------------------
>
> Key: LOG4J2-985
> URL: https://issues.apache.org/jira/browse/LOG4J2-985
> Project: Log4j 2
> Issue Type: Improvement
> Components: Filters
> Affects Versions: 2.2
> Reporter: Remko Popma
> Priority: Minor
> Fix For: 2.3
>
>
> For the same reasons as LOG4J2-891 was raised, {{equals()}} and
> {{hashCode()}} should be removed from {{AbstractFilter}}.
> Similar to the approach for {{AbstractFilter}} I will keep the existing
> implementation of equals() and rename it {{equalsImpl()}} (with the call to
> {{super.equals(obj)}} replaced by {{super.equalsImpl(obj)}}).
> Similarly for hashCode() to {{hashCodeImpl()}}. The xxxImpl() methods will be
> protected, similar to the approach taken in {{AbstractFilter}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
