[
https://issues.apache.org/jira/browse/LOG4J2-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493398#comment-14493398
]
Ralph Goers commented on LOG4J2-995:
------------------------------------
In reviewing the Charsets class only the UTF_8 constant is actually used
outside of test code. The other constants and the methods are only used in test
code. The single UTF_8 constant should really just be moved to the Constants
class and the Charsets class removed.
> Improve documentation of Charsets class
> ---------------------------------------
>
> Key: LOG4J2-995
> URL: https://issues.apache.org/jira/browse/LOG4J2-995
> Project: Log4j 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.2
> Reporter: Ralph Goers
> Assignee: Ralph Goers
> Fix For: 2.3
>
>
> The javadoc for org.apache.logging.log4j.core.util.Charsets gives the
> impression that the class was somehow copied from code in the JDK. In
> reviewing the code it is clear that the purpose of the class was to make a
> version of the charset constants defined in Java 7 and beyond available in
> Java 6. As such, the names of the constants will necessarily be similar and
> there is only one reasonable way to initialize them.
> The javadoc should be changed to make it clear what the purpose of the class
> is and identify the constants as a reference to the StandardCharsets class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
