[
https://issues.apache.org/jira/browse/LOG4J2-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510118#comment-14510118
]
Ralph Goers edited comment on LOG4J2-998 at 4/24/15 12:12 AM:
--------------------------------------------------------------
Not that making the method protected is a bad idea, but it seems to me that you
really are either finding a problem in the ClassLoaderContextSelector or you
need a customized ContextSelector. Having to wrap the Logger class as you are
doing just feels wrong.
Furthermore, contextSelector.getContext(getName(), currentClassLoader,
true).getLogger(getName(), getMessageFactory()) is not a cheap operation and
having to do it for each log event is going to slow down logging tremendously.
Can you provide an example where the ClassLoader structure causes the problems
you are trying to address?
was (Author: [email protected]):
Not that making the method protected is a bad idea, but it seems to me that you
really are either finding a problem in the ClassLoaderContextSelector or you
need a customized ContextSelector. Having to wrap the Logger class as you are
doing just feels wrong.
Furthermore, contextSelector.getContext(getName(), currentClassLoader,
true).getLogger(getName(), getMessageFactory()) is not a cheap operation and
having to do it for each log event is going to slow down logging tremendously.
> Make org.apache.logging.log4j.core.Logger#updateConfiguration protected
> -----------------------------------------------------------------------
>
> Key: LOG4J2-998
> URL: https://issues.apache.org/jira/browse/LOG4J2-998
> Project: Log4j 2
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.1
> Reporter: Mariano Gonzalez
> Fix For: 2.3
>
>
> Hello,
> I'm using log4j2 as the foundation for a centralized logging infrastructure
> inside an application container. For such requirement, I need to be able to
> override the org.apache.logging.log4j.core.Logger#updateConfiguration method.
> However, that method has package visibility and thus cannot be gracefully
> overriden.
> It'd be great if that method could be protected so that subclasses can
> redefine it.
> Thanks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
