[
https://issues.apache.org/jira/browse/LOG4J2-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518836#comment-14518836
]
Gary Gregory commented on LOG4J2-997:
-------------------------------------
[~mchinavan]: Thank you for submitting another patch! :-)
[[email protected]], [[email protected]], and all: Looking at the
implementation for these fixes and at the class itself, it feels that we did
not get the API right for the {{AbstractFilterable}} class. The gymnastics we
do depending on whether the class has a single filter or a composite filter
does not smell right to me.
If the API has an {{addFilter()}} method, I expect to be able to get a list of
all the filters I added, even if it is a list of one. Having a {{Filter
getFilter()}} method fells like it is completely at odds with an
{{addFilter()}} method.
In my mind, we should just have the pair of methods {{addFilter()}} and
{{List<Filter> getFilters()}}.
Thoughts?
Gary
> removeFilter() in AbstractFilterable does not remove filter
> -----------------------------------------------------------
>
> Key: LOG4J2-997
> URL: https://issues.apache.org/jira/browse/LOG4J2-997
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.2
> Reporter: Maytee Chinavanichkit
>
> Add two filters to a class that implements AbstractFilterable. Try to remove
> one of the two filters; nothing is removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
