[
https://issues.apache.org/jira/browse/LOG4J2-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614992#comment-14614992
]
Ralph Goers commented on LOG4J2-812:
------------------------------------
The benchmark is fine. It was the actual DatePatternConverter class that
wasn't changed properly. The benchmark doesn't use that class as it is
simulating the various ways it could be implemented.
> Performance optimization: avoid use of synchronized SimpleDateFormat in
> DatePatternConverter
> -----------------------------------------------------------------------------------------------
>
> Key: LOG4J2-812
> URL: https://issues.apache.org/jira/browse/LOG4J2-812
> Project: Log4j 2
> Issue Type: Bug
> Components: Pattern Converters, Performance Benchmarks
> Affects Versions: 2.0.2
> Reporter: Mohit Anchlia
> Assignee: Remko Popma
> Fix For: 2.3
>
> Attachments: LOG4J2-812-patch.txt, LOG4J2-812.patch2.diff
>
>
> Threads seem to be blocking on class
> org.apache.loggin.log4j.core.pattern.DatePatternConverter. It's short
> lived but is visible in profiler. It also is adding on to CPU. Here is the
> mail conversation on the mailing list:
> {quote}
> Ralph Goers [email protected] via logging.apache.org
> The converter uses a SimpleDateFormat which is not thread safe and so is
> synchronized. I am sure there might be minor optimizations that could be done
> to this
> What I would do is modify DatePatternConverter to
> a) use Java 8’s java.time.format.DateTimeFormatter if running on Java 8
> b) use Joda Time’s DateTimeFormat if it is present.
> c) create a pool of SimpleDateFormat objects and use those.
> Please create a Jira issue for this.
> Ralph
> {quote}
> ----
> One alternative that was suggested on the mailing list is to use commons
> lang FastDateFormat to format log timestamps.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
