I don't think you can, but I am on the road and can't look now. Ralph
Sent from my iPhone > On Aug 9, 2015, at 9:10 AM, Gary Gregory <[email protected]> wrote: > > Patch committed to git master. Thank you for the review. > > Now I see code in log4j-1.2.-api that also type casts to the Core's > LoggerContext from org.apache.log4j.Category.PrivateManager. > > In fact there are 3 versions/copies of PrivateManager in Category, > LogManager, and Logger. > > Should we: > (1) Have one package private implementaion > (2) Avoid the type casts. > > ? > >> On Sun, Aug 9, 2015 at 5:17 AM, Ralph Goers <[email protected]> >> wrote: >> Nope. I am fine with this change. Thanks for asking! >> >> Ralph >> >>> On Aug 9, 2015, at 2:46 AM, Gary Gregory <[email protected]> wrote: >>> >>> I have a patch that does not warrant a JIRA on pastebin at >>> http://pastebin.com/dckkjc0T >>> >>> It replaces calls like: >>> >>> final LoggerContext context = (LoggerContext) >>> LogManager.getContext(false); >>> >>> with new LoggerContext methods like: >>> >>> final LoggerContext context = LoggerContext.getContext(false); >>> >>> as I find the type casts we have all over the place distasteful. >>> >>> If it were just me, I'd apply it, but I am looking for feedback since >>> perhaps the type cast is an intentional marker that once it jumping from >>> the API into the Core. >>> >>> Gary >>> >>> -- >>> E-Mail: [email protected] | [email protected] >>> Java Persistence with Hibernate, Second Edition >>> JUnit in Action, Second Edition >>> Spring Batch in Action >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > JUnit in Action, Second Edition > Spring Batch in Action > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory
