[
https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742523#comment-14742523
]
Ralph Goers commented on LOG4J2-1121:
-------------------------------------
It appears I added waitForCompletion on May 12, 2012. I recall that at the time
I ran into a situation where stopping the configuration was happening faster
than finishing logging an event on a different thread. At that time, the stop
method on the appenders was happening after the call to clearAppenders() so
waitForCompletion was also making sure that stop wasn't being called until all
loggers were done logging with the old configuration.
It appears that at some point calling stop was moved to precede the call to
clearAppenders, which means the call to waitForCompletion is pointless. The way
the code is now it seems to me that a logger could be logging an event and hit
a stopped appender.
> LoggerConfig performance improvement: remove waitForCompletion and associated
> fields
> ------------------------------------------------------------------------------------
>
> Key: LOG4J2-1121
> URL: https://issues.apache.org/jira/browse/LOG4J2-1121
> Project: Log4j 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.3
> Reporter: Remko Popma
>
> This ticket follows up on LOG4J2-1120. Out of the three changes identified in
> LOG4J2-1120, only two could be implemented in time for the 2.4 release.
> This ticket tracks the remaining work for the third change:
> * Since {{clearAppenders()}} is only called after all appenders have been
> stopped, {{waitForCompletion()}} may no longer be necessary (unless I am
> missing something here). If so, the {{shutdownLock}}, {{shutdown}} and
> {{counter}} fields can be removed. Not incrementing the atomic counters with
> every event in the hot path should give better performance.
> LOG4J2-1120 shows benchmark results that support this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
