[
https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877321#comment-14877321
]
Remko Popma edited comment on LOG4J2-1121 at 9/19/15 9:12 PM:
--------------------------------------------------------------
I created a branch {{LOG4J2-1121B-ReliabilityStrategy}} that combines some of
Ralph's ideas and feedback with my proposal to increase the counter before
calling either of the LoggerConfig.log methods. The logic is now extracted in a
ReliabilityStrategy. The existing logic is in
AwaitCompletionReliabilityStrategy. Feedback welcome.
(I realized that using the DefaultReliabilityStrategy in
DefaultConfigurationMonitor ignores the fact that a reconfigure may be
triggered programmatically in addition to the configuration file being
modified. So that needs to change.)
was (Author: [email protected]):
I created a branch {{LOG4J2-1121B-ReliabilityStrategy}} that combines some of
Ralph's ideas and feedback with my proposal to increase the counter before
calling either of the LoggerConfig.log methods. The logic is now extracted in a
ReliabilityStrategy. The existing logic is in
AwaitCompletionReliabilityStrategy. Feedback welcome.
> LoggerConfig performance improvement: remove waitForCompletion and associated
> fields
> ------------------------------------------------------------------------------------
>
> Key: LOG4J2-1121
> URL: https://issues.apache.org/jira/browse/LOG4J2-1121
> Project: Log4j 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.3
> Reporter: Remko Popma
>
> This ticket follows up on LOG4J2-1120. Out of the three changes identified in
> LOG4J2-1120, only two could be implemented in time for the 2.4 release.
> This ticket tracks the remaining work for the third change:
> * Since {{clearAppenders()}} is only called after all appenders have been
> stopped, {{waitForCompletion()}} may no longer be necessary (unless I am
> missing something here). If so, the {{shutdownLock}}, {{shutdown}} and
> {{counter}} fields can be removed. Not incrementing the atomic counters with
> every event in the hot path should give better performance.
> LOG4J2-1120 shows benchmark results that support this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
