See the email I just sent. That isn’t a reason for which I would consider failing a release candidate. Of course, you are free to vote -1, but it is not a veto.
Ralph > On Oct 11, 2015, at 4:18 PM, Matt Sicker <[email protected]> wrote: > > -1, have a simple bug fix for LOG4J2-1099 that would be handy to include. > Already in master with tests, so I believe we can include this. > > On 11 October 2015 at 14:09, Gary Gregory <[email protected] > <mailto:[email protected]>> wrote: > I am not home until later. I probably won't be able to review until tomorrow > realistically. > > Gary > > > -------- Original message -------- > From: Ralph Goers <[email protected] > <mailto:[email protected]>> > Date: 10/11/2015 10:57 (GMT-08:00) > To: Logging PMC <[email protected] > <mailto:[email protected]>> > Cc: Log4J Developers List <[email protected] > <mailto:[email protected]>> > Subject: Re: [VOTE] Log4j 2.4.1 rc1 > > If anyone is available to review this today please do. I would really like to > finish the release process tonight after the 72 hours are up as I don’t know > how busy I am going to be during the week. > > Ralph > >> On Oct 11, 2015, at 3:12 AM, Ralph Goers <[email protected] >> <mailto:[email protected]>> wrote: >> >> Here is my +1. We still need one more vote. >> >> Ralph >> >> On Oct 8, 2015, at 8:33 PM, Ralph Goers <[email protected] >> <mailto:[email protected]>> wrote: >> >>> This is a vote to release Log4j 2.4.1, the next version of the Log4j 2 >>> project. >>> >>> Please download, test, and cast your votes on the log4j developers list. >>> [] +1, release the artifacts >>> [] -1, don't release because... >>> >>> The vote will remain open for 72 hours (or more if required). All votes are >>> welcome, but only Logging PMC votes are “officially” counted. As always, at >>> least 3 +1 votes and more positive than negative votes are required. >>> Changes in this version include: >>> >>> New features: >>> o LOG4J2-1129: Allow PatternLayout to select a pattern to use based on >>> some selection criteria. >>> o LOG4J2-1145: Add %equals to PatternLayout to test and replace patterns >>> with strings. >>> o LOG4J2-1147: Add %equalsIgnoreCase to PatternLayout to test and replace >>> patterns with strings. >>> o LOG4J2-1146: Add %notEmpty to PatternLayout to avoid output of patterns >>> where all variables are empty. >>> o LOG4J2-1020: Add possibility to set shutdown timeout on AsyncAppender. >>> >>> Fixed Bugs: >>> o LOG4J2-1153: Fixed NullPointerException when only root logger is defined >>> (and no named loggers) in configuration properties file. >>> o LOG4J2-1140: Fixed bug where headers were not being written to first >>> file with RollingFileAppender. >>> o LOG4J2-1149: Fixed bug where PatternLayout predefined date pattern with >>> time zone always renders default date format. >>> o LOG4J2-1050: Fixed Log4jLookup. >>> o LOG4J2-1142: Fix potential memory leak in web applications by using a >>> straight ThreadLocal field instead of subclassing ThreadLocal. >>> o LOG4J2-1135: Compression on rollover was broken: log file was renamed to >>> .zip but not compressed. >>> o LOG4J2-1127: log4j2.xml cannot be parsed on Oracle Weblogic 12c. >>> o LOG4J2-1132: Do not use MongoDB driver 2.13.3 deprecated methods. >>> o LOG4J2-1144: Add %markerSimpleName in pattern layout should evaluate to >>> marker name (not toString()). >>> o LOG4J2-1126: Web site corrections and updates. >>> >>> Changes: >>> o LOG4J2-1151: Performance improvement: backport Java 8 fast ISO-8859-1 >>> String to byte[] encoder to AbstractStringLayout. >>> o LOG4J2-935: Performance improvement when converting Strings to byte[] >>> arrays. >>> o LOG4J2-1040: Update MongoDB driver from 2.13.3 to 3.0.4. >>> o LOG4J2-1128: Reuse StringBuilder to improve performance for String-based >>> layouts: CSV, GELF, HTML, RFC524, Syslog. >>> o LOG4J2-1131: Update mongo-java-driver from 2.13.2 to 2.13.3. >>> o LOG4J2-1138: Do not use Jackson deprecated methods. >>> o LOG4J2-1139: Update Jackson from 2.6.1 to 2.6.2. >>> o LOG4J2-1150: Update kafka-clients from 0.8.2.1 to 0.8.2.2. >>> Tag: >>> https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;a=commit;h=bd929b829d5d019cff4640a63007adab71d752df >>> >>> <https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;a=commit;h=bd929b829d5d019cff4640a63007adab71d752df> >>> or >>> a) for a new copy do "git clone >>> https://git-wip-us.apache.org/repos/asf/logging-log4j2.git >>> <https://git-wip-us.apache.org/repos/asf/logging-log4j2.git>" and then "git >>> checkout tags/log4j-2.4.1" >>> b) for an existing working copy to “git pull” and then “git checkout >>> tags/log4j-2.4.1” >>> >>> Web Site: http://people.apache.org/~rgoers/log4j2/ >>> <http://people.apache.org/~rgoers/log4j2/> >>> >>> Artifacts: >>> https://repository.apache.org/content/repositories/orgapachelogging-1016/ >>> <https://repository.apache.org/content/repositories/orgapachelogging-1016/> >>> >>> You may download all the artifacts by executing: >>> >>> wget -e robots=off --cut-dirs=7 -nH -r -p -np --no-check-certificate >>> https://repository.apache.org/content/repositories/orgapachelogging-1016/org/apache/logging/log4j/ >>> >>> <https://repository.apache.org/content/repositories/orgapachelogging-1016/org/apache/logging/log4j/> >>> Ralph >>> > > > > > -- > Matt Sicker <[email protected] <mailto:[email protected]>>
