[ 
https://issues.apache.org/jira/browse/LOG4J2-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959468#comment-14959468
 ] 

Gary Gregory commented on LOG4J2-1161:
--------------------------------------

I would not have "value" in the method, "put" does not have "value" in its 
name, so why should "with", The put and with methods are the same except for 
the fluent API style. Too pad we cannot change the signature of put(), that 
would break BC. 

Then I would pull "with" up to MapMessage. 

Maybe there is a method name that is more in line with "put", like what though? 
putKeyValue? putMapEntry? add?

> Builder like pattern to add values to MapMessage
> ------------------------------------------------
>
>                 Key: LOG4J2-1161
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1161
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: 2.4.1
>            Reporter: Mikael Ståldal
>            Priority: Minor
>
> It would be nice to have a builder like pattern to add values to 
> {{MapMessage}} and its subclass {{StructuredDataMessage}}, so you can do 
> {code}
>         EventLogger.logEvent(
>             new StructuredDataMessage(confirm, null, "transfer")
>                 .withValue("toAccount", toAccount)
>                 .withValue("fromAccount", fromAccount)
>                 .withValue("amount", amount)
>         );
> {code}
> instead of
> {code}
>         StructuredDataMessage msg = new StructuredDataMessage(confirm, null, 
> "transfer");
>         msg.put("toAccount", toAccount);
>         msg.put("fromAccount", fromAccount);
>         msg.put("amount", amount);
>         EventLogger.logEvent(msg);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to