[ 
https://issues.apache.org/jira/browse/LOG4J2-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020537#comment-15020537
 ] 

Ralph Goers commented on LOG4J2-1034:
-------------------------------------

We definitely should allow comments.  Doing a quick google search I couldn't 
find the above as being a valid syntax anywhere.

> JsonConfiguration.getObjectMapper may more friendly to json
> -----------------------------------------------------------
>
>                 Key: LOG4J2-1034
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1034
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Configurators
>    Affects Versions: 2.5
>            Reporter: takeseem
>            Priority: Minor
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Thanks.
> It's a good idea for JsonConfiguration: 
>  * allow unquoted field names
>  * allow single quotes
> org.apache.logging.log4j.core.config.json.JsonConfiguration.getObjectMapper
> {code}
>     protected ObjectMapper getObjectMapper() {
>         return new 
> ObjectMapper().configure(JsonParser.Feature.ALLOW_UNQUOTED_FIELD_NAMES, 
> true).configure(JsonParser.Feature.ALLOW_SINGLE_QUOTES, 
> true).configure(JsonParser.Feature.ALLOW_COMMENTS, true);
>     }
> {code}
> v2.3: 
> {code}
>     protected ObjectMapper getObjectMapper() {
>         return new 
> ObjectMapper().configure(JsonParser.Feature.ALLOW_COMMENTS, true);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to