[
https://issues.apache.org/jira/browse/LOG4J2-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153594#comment-15153594
]
Remko Popma commented on LOG4J2-1255:
-------------------------------------
Taking another good hard look at this, we currently have a lot of entry/exit
methods:
{code}
entry() : void // deprecated
entry(Object...) : void
exit() : void // deprecated
exit(R) : R // deprecated
traceEntry() : EntryMessage
traceEntry(String, Object...) : EntryMessage
traceEntry(Supplier...) : EntryMessage
traceEntry(String, Supplier...) : EntryMessage
traceEntry(Message) : EntryMessage
traceExit() : void
traceExit(R) : R
traceExit(String, R) : R
traceExit(EntryMessage) : void
traceExit(EntryMessage, R) : R
traceExit(Message, R) : R
// assume we deprecate MessageSupplier and remove these methods
traceEntry(String, MessageSupplier...) : EntryMessage
traceEntry(MessageSupplier) : EntryMessage
traceExit(MessageSupplier, R) : R
{code}
Do we really need all of them? How about cutting it down to something like this?
{code}
entry() : void // deprecated
entry(Object...) : void
exit() : void // deprecated
exit(R) : R // deprecated
traceEntry() : EntryMessage
traceEntry(String, Object...) : EntryMessage
traceEntry(Message) : EntryMessage
traceExit() : void
traceExit(R) : R
traceExit(String, R) : R
traceExit(Message, R) : R
{code}
I propose leaving out Suppliers altogether in the initial cut until there is a
need.
Gary, would this cover your use cases?
> Logger.entry and Logger.exit should support Messages.
> -----------------------------------------------------
>
> Key: LOG4J2-1255
> URL: https://issues.apache.org/jira/browse/LOG4J2-1255
> Project: Log4j 2
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.5
> Reporter: Ralph Goers
> Assignee: Ralph Goers
> Fix For: 2.6
>
>
> Logger.entry and Logger.exit currently do not support Message objects. This
> reduces the flexibility of what can be logged on entry and exit to methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
