[
https://issues.apache.org/jira/browse/LOG4J2-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210688#comment-15210688
]
Andrew Bernhagen commented on LOG4J2-1323:
------------------------------------------
Hey Gary,
Pattern processor also looks better, thanks for adding those in.
I really wanted to use the stock JsonLayout implementation, but due to some
more legacy requirements (that are rooted from Log4j1), we've had to hack
together the standard PatternLayout to simulate JSON. I hope we can eventually
update to use the JsonLayout. I did look at that class and I didn't see any
issues there.
Regarding the RollingFileManager, it'd be great if the inner static classes
were protected so they are available when extending it. I think that was the
only issue I encountered with that.
Note that I've gotten most of my extensions to work with some static
initialization. It works for my needs, but I'll make it a little more flexible
in the future as new releases become available.
Thank you very much for your help.
> Remove Final Declarations on Many Classes/Methods
> -------------------------------------------------
>
> Key: LOG4J2-1323
> URL: https://issues.apache.org/jira/browse/LOG4J2-1323
> Project: Log4j 2
> Issue Type: Wish
> Components: API, Appenders, Pattern Converters
> Affects Versions: 2.5
> Reporter: Andrew Bernhagen
> Labels: architecture, easyfix, newbie, patch
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Within my organization, I've had to develop a custom appender that
> automatically configures certain properties and a specific layout to tie into
> other initiatives we have tied to logging. Log4j2 made this much more
> difficult than Log4j1 due to the use of final on many classes (e.g. the
> appender implementations) and methods (all pattern layout methods). This has
> made extension overly difficult and filled with a lot of copy and paste that
> I'd rather not have. Is it possible that these could be removed to make it
> easier to extend the existing implementations?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
