[ 
https://issues.apache.org/jira/browse/LOG4J2-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242294#comment-15242294
 ] 

Remko Popma commented on LOG4J2-1365:
-------------------------------------

What if we simply let some Messages implement the {{CharSequence}} interface 
instead?  I would like that a lot better.

The relevant GelfLayout code would look something like:
{code}
Message message = event.getMessage();
if (message instanceof CharSequence) {
        JsonUtils.quoteAsString(toNullSafeString((CharSequence) message), 
builder);
} else if (gcFree && message instanceof StringBuilderFormattable) {
...
{code}

> Add CharSequenceFormattable interface for Messages to improve performance of 
> Layouts
> ------------------------------------------------------------------------------------
>
>                 Key: LOG4J2-1365
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1365
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Layouts
>    Affects Versions: 2.5
>            Reporter: Mikael Ståldal
>            Assignee: Mikael Ståldal
>            Priority: Minor
>
> {code}
> public interface CharSequenceFormattable {
>     CharSequence getFormattedCharSequence();
> }
> {code}
> This can be implemented by Messages where it makes sense and used by Layouts 
> where it makes sense.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to