FYI, the relevant commit email is titled "[1/7] logging-log4j2 git commit: LogEvent memento".
On Thu, May 5, 2016 at 2:08 AM, Remko Popma <[email protected]> wrote: > This change essentially moves all duplicate logic that called > Log4jLogEvent.deserialize(Log4jLogEvent.serialize(event)) into a single > place. > There should not be any change in behaviour. > (Unless I overlooked something.) > > On Thu, May 5, 2016 at 2:05 AM, Gary Gregory <[email protected]> > wrote: > >> Cool. Any idea how that affects speed or memory? Does it matter? >> >> Gary >> On May 4, 2016 8:59 AM, "Remko Popma" <[email protected]> wrote: >> >>> I reviewed the LOG4J2-1347 branch and I like the work Mikael did here. >>> Replacing >>> the deserialize(serialize(logevent)) sequences with >>> Log4jLogEvent.createMemento() looks cleaner. >>> >>> I could not see any issue and I don't mind if these changes are merged >>> into master. >>> >>> (Implementing the feature requested in LOG4J2-1347 is a separate thing >>> and will require more work.) >>> >>> Remko >>> >> >
