I fixed the license header issues. Found a bug in how properties were being
merged into composite configurations - that was causing the problem with
${filename}.
Now all I need is to get my personal MacBook Pro to be able to boot.
Ralph
> On May 21, 2016, at 5:57 PM, Remko Popma <[email protected]> wrote:
>
> About the ThreadContext map in JSON/YAML format: towards the end I see a
> comment from Ralph that the current output is wrong. If you have the
> bandwidth I'd say go ahead and fix it.
>
> On Friday, 20 May 2016, Mikael Ståldal <[email protected]
> <mailto:[email protected]>> wrote:
> What about the format for thread context map in JsonLayout and YamlLayout?
>
> https://issues.apache.org/jira/browse/LOG4J2-1362
> <https://issues.apache.org/jira/browse/LOG4J2-1362>
>
> https://issues.apache.org/jira/browse/LOG4J2-623
> <https://issues.apache.org/jira/browse/LOG4J2-623>
>
> Currently it is:
>
> {
> "timeMillis" : 1463730772138,
> "thread" : "main",
> "level" : "INFO",
> "loggerName" : "HelloWorld",
> "message" : "Hello, world!",
> "contextStack" : [ "one", "two" ],
> "endOfBatch" : false,
> "loggerFqcn" : "org.apache.logging.log4j.spi.AbstractLogger",
> "contextMap" : [ {
> "key" : "bar",
> "value" : "BAR"
> }, {
> "key" : "foo",
> "value" : "FOO"
> } ],
> "threadId" : 1,
> "threadPriority" : 5
> }
>
> and:
>
> ---
> timeMillis: 1463730772138
> thread: "main"
> level: "INFO"
> loggerName: "HelloWorld"
> message: "Hello, world!"
> contextStack:
> - "one"
> - "two"
> endOfBatch: false
> loggerFqcn: "org.apache.logging.log4j.spi.AbstractLogger"
> contextMap:
> - key: "bar"
> value: "BAR"
> - key: "foo"
> value: "FOO"
> threadId: 1
> threadPriority: 5
>
>
> On Thu, May 19, 2016 at 8:50 PM, Ralph Goers <[email protected]
> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:
> In fixing the problem with ${filename} I found a bug. I am still debugging
> the second test that is creating that file. Given the slow internet at my
> hotel I may have to wait til next week.
>
> Ralph
>
> On May 19, 2016, at 10:37 AM, Remko Popma <[email protected]
> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:
>
>> I've been making minor edits to the site and docs, but please feel free to
>> start the release whenever you are ready.
>>
>> On Thu, May 19, 2016 at 12:06 AM, Remko Popma <[email protected]
>> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:
>> I fixed 3 license issues (GilsDosAndDontsLatencyTesting.txt,
>> log4j-perf/src/main/resources/perf-WithoutAnyAppender-location.xml, and
>> src/main/resources/perf-WithoutAnyAppender.xml).
>>
>> On Wed, May 18, 2016 at 8:30 PM, Ralph Goers <[email protected]
>> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:
>> Thanks for finding it. I will fix it.
>>
>> Ralph
>>
>>> On May 18, 2016, at 6:02 AM, Remko Popma <[email protected]
>>> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:
>>>
>>> ${filename} is created by CompositeConfigurationTest, ::compositeLogger and
>>> ::testReconfiguration
>>>
>>> I don't know why though. Can someone else fix that?
>>>
>>> I will fix the license issues for GilsDosAndDontsLatencyTesting.txt,
>>>> src/main/resources/perf-WithoutAnyAppender-location.xml, and
>>>> src/main/resources/perf-WithoutAnyAppender.xml
>>>
>>> Remko
>>>
>>> Sent from my iPhone
>>>
>>> On 2016/05/18, at 13:12, Ralph Goers <[email protected]
>>> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:
>>>
>>>> There are 2 files with unapproved licenses in log4j-core: ${filename} and
>>>> src/test/java/org/apache/logging/log4j/core/async/perftest/GilsDosAndDontsLatencyTesting.txt.
>>>> Obviously the first is a build error but I am not sure if the second is
>>>> meant to be there. If it is it needs an apache license header. We need to
>>>> figure out which test is generating the ${filename} and fix it.
>>>>
>>>> There are 3 files with unapproved licenses in log4j-perf: perf.txt (my
>>>> fault and needs to be deleted),
>>>> src/main/resources/perf-WithoutAnyAppender-location.xml, and
>>>> src/main/resources/perf-WithoutAnyAppender.xml.
>>>>
>>>> These need to be fixed before I can release.
>>>>
>>>> Ralph
>>>>
>>>>
>>>>
>>>>> On May 17, 2016, at 12:35 PM, Gary Gregory <[email protected]
>>>>> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:
>>>>>
>>>>> No need to torture yourself with slow internet. We can wait a few days
>>>>> no? That would give us all time or at least myself to review the current
>>>>> code. But I can't look until tonight at the earliest...
>>>>>
>>>>> Gary
>>>>>
>>>>> On Tue, May 17, 2016 at 8:15 AM, Ralph Goers <[email protected]
>>>>> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:
>>>>> The performance page has been completed. Is there anything left to do
>>>>> before the 2.6 release build? If not I can start it tonight - I hope.
>>>>> The wireless speed at my hotel is terrible so I have to use the hotspot
>>>>> on my phone.
>>>>>
>>>>> Ralph
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: [email protected]
>>>>> <javascript:_e(%7B%7D,'cvml','[email protected]');>
>>>>> For additional commands, e-mail: [email protected]
>>>>> <javascript:_e(%7B%7D,'cvml','[email protected]');>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> E-Mail: [email protected]
>>>>> <javascript:_e(%7B%7D,'cvml','[email protected]');> |
>>>>> [email protected] <javascript:_e(%7B%7D,'cvml','[email protected]');>
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> <http://www.manning.com/bauer3/>
>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>> Blog: http://garygregory.wordpress.com
>>>>> <http://garygregory.wordpress.com/>
>>>>> Home: http://garygregory.com/ <http://garygregory.com/>
>>>>> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
>>
>>
>>
>
>
>
> --
>
>
> Mikael Ståldal
> Senior software developer
>
> Magine TV
> [email protected]
> <javascript:_e(%7B%7D,'cvml','[email protected]');>
> Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com
> <http://www.magine.com/>
>
> Privileged and/or Confidential Information may be contained in this message.
> If you are not the addressee indicated in this message
> (or responsible for delivery of the message to such a person), you may not
> copy or deliver this message to anyone. In such case,
> you should destroy this message and kindly notify the sender by reply email.
>