If the first file on the stream is non-zero length, and the second file is zero length, then won't the test fail?
On Sun, Jun 12, 2016 at 2:45 PM, Ralph Goers <[email protected]> wrote: > Looked at the test again. It had some bugs in it. > > Ralph > > On Jun 11, 2016, at 10:22 PM, Ralph Goers <[email protected]> > wrote: > > Yes. It creates the file and writes to it. The test should then end and > run again. On the second run the file should roll over. The files should > both have the header, footer, and same number of lines so they should be > the same size. > > Ralph > > On Jun 11, 2016, at 10:08 PM, Remko Popma <[email protected]> wrote: > > Hm... this is the second time I see this test fail: > Stacktrace > > java.lang.AssertionError > at > org.apache.logging.log4j.core.appender.rolling.RollingAppenderOnStartupTest.afterClass(RollingAppenderOnStartupTest.java:85) > > > What does this test do? It looks like it remembers the size of the first > non-empty file in the directory, and then asserts that all other files are > the same size, is that correct? > > @AfterClass > public static void afterClass() throws Exception { > long size = 0; > try (DirectoryStream<Path> directoryStream = > Files.newDirectoryStream(Paths.get("target/onStartup"))) { > for (Path path : directoryStream) { > if (size == 0) { > size = Files.size(path); > } else { > assertTrue(size == Files.size(path)); // <- line 85 > } > Files.delete(path); > } > Files.delete(Paths.get("target/onStartup")); > } > } > > > > > > > > > > > On Sun, Jun 12, 2016 at 1:17 PM, Apache Jenkins Server < > [email protected]> wrote: > >> See <https://builds.apache.org/job/Log4j%202.x/2019/changes> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > >
