Now you have gotten way off topic. See http://logging.apache.org/log4j/2.x/changes-report.html#a2.6.2 <http://logging.apache.org/log4j/2.x/changes-report.html#a2.6.2>. When you make a commit, the way you give yourself public credit for the work is via the dev attribute. That shows up in the “By” column. When you want to give thanks to a contributor you add the due-to attribute and then the plugin adds the “Thanks to” to the description of the change. It just looks weird for you to be thanking yourself for the change as you are already getting the credit in the “By” column and the fact that no one else is being thanked.
By the same token, we always want to recognize contributors for their patches. So they should always be specified in the “due-to”. Even if you collaborate I still prefer to leave myself off as I want to encourage people to keep contributing patches. Ralph > On Aug 26, 2016, at 4:16 PM, Matt Sicker <[email protected]> wrote: > > I think we should sign tags. By signing a tag, everything up to that point is > verifiable via sha1 hashes. I'm not sure if the maven release plugin does > this already, but it would be nice. > > On 26 August 2016 at 18:13, Gary Gregory <[email protected] > <mailto:[email protected]>> wrote: > On Fri, Aug 26, 2016 at 4:04 PM, Matt Sicker <[email protected] > <mailto:[email protected]>> wrote: > We don't gpg-sign commits, so it wouldn't really matter. It's more useful in > larger projects where you have a hierarchy of project leaders involved. > > Should we sign commits? > > Gary > > > On 26 August 2016 at 18:02, Gary Gregory <[email protected] > <mailto:[email protected]>> wrote: > Are you suggesting we augment the changes.xml model to reflect the 3rd attr? > > G > > On Fri, Aug 26, 2016 at 4:02 PM, Matt Sicker <[email protected] > <mailto:[email protected]>> wrote: > Git has 3 distinctions though: author, committer, and signed off by (which is > optional). > > On 26 August 2016 at 18:00, Gary Gregory <[email protected] > <mailto:[email protected]>> wrote: > Maybe we can use the dev attr for the person who commits and the due-to attr > as the actual author; kind of like git's distinction. > > ? > > Gary > > On Fri, Aug 26, 2016 at 3:52 PM, Matt Sicker <[email protected] > <mailto:[email protected]>> wrote: > What about when you collaborate with a contributor? For example, a > half-finished patch. > > On 26 August 2016 at 17:47, Gary Gregory <[email protected] > <mailto:[email protected]>> wrote: > Copy-paste. Would you rather it does not show up with a due-to? > > Gary > > On Fri, Aug 26, 2016 at 3:05 PM, Ralph Goers <[email protected] > <mailto:[email protected]>> wrote: > Gary, > > I am noticing that you have marked several items in changes.xml as “due-to” > yourself? Why are you doing that? Traditionally, we have omitted that when a > committer does the work as it shows up as you making the commit in the report. > > Ralph > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > <mailto:[email protected]> > For additional commands, e-mail: [email protected] > <mailto:[email protected]> > > > > > -- > E-Mail: [email protected] <mailto:[email protected]> | > [email protected] <mailto:[email protected]> > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> > Home: http://garygregory.com/ <http://garygregory.com/> > Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory> > > > -- > Matt Sicker <[email protected] <mailto:[email protected]>> > > > > -- > E-Mail: [email protected] <mailto:[email protected]> | > [email protected] <mailto:[email protected]> > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> > Home: http://garygregory.com/ <http://garygregory.com/> > Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory> > > > -- > Matt Sicker <[email protected] <mailto:[email protected]>> > > > > -- > E-Mail: [email protected] <mailto:[email protected]> | > [email protected] <mailto:[email protected]> > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> > Home: http://garygregory.com/ <http://garygregory.com/> > Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory> > > > -- > Matt Sicker <[email protected] <mailto:[email protected]>> > > > > -- > E-Mail: [email protected] <mailto:[email protected]> | > [email protected] <mailto:[email protected]> > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> > Home: http://garygregory.com/ <http://garygregory.com/> > Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory> > > > -- > Matt Sicker <[email protected] <mailto:[email protected]>>
