[ 
https://issues.apache.org/jira/browse/LOG4J2-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456677#comment-15456677
 ] 

Gary Gregory edited comment on LOG4J2-1557 at 9/1/16 9:35 PM:
--------------------------------------------------------------

I'll update the description. 

I do not have an itch to add builders all over (YAGNI) but I clearly see now 
that converting to a builder is the right first step when you plan on adding 
new options.



was (Author: garydgregory):
I'll update the description.


> Add a Builder for the SocketAppender (deprecates factory method)
> ----------------------------------------------------------------
>
>                 Key: LOG4J2-1557
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1557
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Appenders
>            Reporter: Gary Gregory
>            Assignee: Gary Gregory
>             Fix For: 2.7
>
>
> Add a {{Builder}} for the {{SocketAppender}} and deprecate the factory method.
> I need to add parameters for {{bufferedIo}} and {{bufferSize}} to the 
> {{SocketAppender}} and the {{SyslogAppender}} as I am embarking on a project 
> that will use Syslog events in large quantities. Then I'd like to also add 
> these to other streaming appenders. I'll create a different ticket for these. 
> Deprecated:
> - 
> org.apache.logging.log4j.core.appender.SocketAppender.createAppender(String, 
> int, Protocol, SslConfiguration, int, int, boolean, String, boolean, boolean, 
> Layout<? extends Serializable>, Filter, boolean, Configuration)
> - 
> org.apache.logging.log4j.core.appender.SocketAppender.createAppender(String, 
> String, String, SslConfiguration, int, String, String, String, String, 
> String, Layout<? extends Serializable>, Filter, String, Configuration)
> When should we deprecate these?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to