[
https://issues.apache.org/jira/browse/LOG4J2-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670935#comment-15670935
]
Gary Gregory commented on LOG4J2-1676:
--------------------------------------
There is no unit test that demonstrate the problem(s) which means if someone
changes the code in the future, no one will know it breaks something.
> Use Message.getThrowable() in log(Message) methods
> --------------------------------------------------
>
> Key: LOG4J2-1676
> URL: https://issues.apache.org/jira/browse/LOG4J2-1676
> Project: Log4j 2
> Issue Type: Bug
> Affects Versions: 2.5, 2.6, 2.7
> Reporter: Joern Huxhorn
> Attachments: 0001-Using-Throwable-of-Message-if-available.patch,
> 0002-Using-Throwable-of-Message-if-not-explicitly-given.patch
>
>
> All {{log(Message)}} methods should use {{Message.getThrowable()}}, e.g.
> {code:java}
> public void debug(final Message msg) {
> logIfEnabled(FQCN, Level.DEBUG, null, msg, msg != null ?
> msg.getThrowable() : null);
> }
> {code}
> instead of the current
> {code:java}
> public void debug(final Message msg) {
> logIfEnabled(FQCN, Level.DEBUG, null, msg, null);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
