[
https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896756#comment-15896756
]
ASF GitHub Bot commented on LOG4J2-1838:
----------------------------------------
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/61
PR overall looks good. I'm curious why you didn't create another
PatternConverter for it, though. Also, this sounds similar to the
variablesNotEmpty converter, so it makes me think even more so that it could be
implemented as such to be more versatile.
> Add support for appending common suffix to each line of throwable stack trace
> -----------------------------------------------------------------------------
>
> Key: LOG4J2-1838
> URL: https://issues.apache.org/jira/browse/LOG4J2-1838
> Project: Log4j 2
> Issue Type: New Feature
> Components: Pattern Converters
> Affects Versions: 2.8.1
> Reporter: Zilong Song
> Labels: features
> Fix For: 2.8.2
>
>
> Add support for appending common suffix to each line of throwable stack
> trace. The suffix can be configured by patterns just like patterns used
> elsewhere.
> For example, pattern {{%xEx{suffix(- %mdc{key})}}} will
> append a string generated by pattern {{- }} and {{%mdc{key}}}.
> But patterns that handles throwable will be automatically ignored, because
> they will make the rendered result confusing. So pattern {{%xEx{suffix(-
> %rEx%mdc{key})}}} has the same effect with
> {{%xEx{suffix(- %mdc{key})}}}, as if the nested {{%rEx}}
> pattern has never appeared.
> Following is an example of the with such suffix:
> {code:title=stack trace, with pattern "%xEx{suffix(-
> %mdc{key})}" and MDC(key)="test mdc suffix"|borderStyle=solid}
> java.lang.IllegalArgumentException: IllegalArgument - test mdc suffix
> at
> org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:48)
> [test-classes/:?] - test mdc suffix
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:1.8.0_91] - test mdc suffix
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:1.8.0_91] - test mdc suffix
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_91] -
> test mdc suffix
> at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)
> [idea_rt.jar:?] - test mdc suffix
> Caused by: java.lang.NullPointerException: null pointer - test mdc suffix
> at
> org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:47)
> ~[test-classes/:?] - test mdc suffix
> ... 27 more - test mdc suffix
> }}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
