I'm not sure what exampled you're referring to showing the public usage -- most everything I could find shows it being either private or "package"...
The two canonical ways of creating Loggers are: private static final Logger LOG = Logger.getLogger(MyClass.class); or private final Logger logger = Logger.getLogger(getClass()); The static route is nice because (assuming you have many more instances than you have classes) it's more efficient, and when it logs you know exactly what class the logging is coming from so it's easy to track down where it happened. However, if it's a class that likely will be extended from, it doesn't tell you exactly what "kind" of instance the calling object really is. The advantages/disadvantages are reversed for the non-static logger. It depends on your needs, of course, but in general the static Logger has the better cost/benefit ratio. That said, making Logger public would actually be an anti-pattern. "Sharing" a Logger between classes makes it extremely difficult and misleading to determine where the logging is taking place. Logger instances aren't zero-cost, but they aren't expensive either, so unless you have extreme performance requirements, it's best to do what makes debugging easier, which is either a Logger-per-class or a Logger-per-instance. If you absolutely need a "public Logger", use the root logger (Logger.getRootLogger()). There are some special-case exceptions, though, that basically boil-down to trying to do AOP without actually doing AOP. An example is having a SQL_LOGGER that's used across classes when doing SQL. That's better handled using other techniques, however. -Jim Moore On Fri, 1 Oct 2004 09:56:57 +0100, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > Hi all > > just a little question. > In all log4j examples I see the logger is integrated as > > public static Logger logger = new Logger(x.class); > > If I understand it correct, it is static to enhance the performance, as > only one instance of the logger is used for all instantiations of class x. > But why is it public? I would make it private as it is referenced only in > the class x, not outside. > > And if i don't want to extend the class x, I would make it final. > > Thus in my example it would be: > private static final Logger logger = new Logger(x.class); > > Are there any arguments speaking against this usage? Please make > suggestions. > > Thanks Herb --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
