Exactly. I think it's good practice to re-build plugins for a library or application with every update, but that's not usually necessary. It would be a good idea to put it in changes.xml somewhere. Any suggestions?
On 19 July 2014 20:51, Remko Popma <remko.po...@gmail.com> wrote: > I see. > Okay, so old plugins that were built before the annotation processor (and > relied on the packages attribute) need to be re-built. > > Perhaps this should also be mentioned in changes.xml (with a note that the > change was made in rc2(?) but was not included in the release notes for > that release). > > > On Sun, Jul 20, 2014 at 10:04 AM, Matt Sicker <boa...@gmail.com> wrote: > > > I removed it a while ago after the annotation processor was duplicating > its > > functionality (in PluginManager). Since an annotation processor can also > be > > run on its own using the java compiler, it didn't make sense to provide > > another tool that does the same thing. > > > > > > On 19 July 2014 19:21, Remko Popma <remko.po...@gmail.com> wrote: > > > > > By the way, just out of interest, how come the packages attribute no > > longer > > > works? > > > Is this related to the discussion in LOG4J2-673 > > > <https://issues.apache.org/jira/browse/LOG4J2-673>? (But I gather from > > the > > > comments that the patch attached to that issue has not been committed > > > yet...) > > > > > > > > > On Sun, Jul 20, 2014 at 9:20 AM, Remko Popma <remko.po...@gmail.com> > > > wrote: > > > > > > > Thanks, Matt! > > > > > > > > > > > > On Sun, Jul 20, 2014 at 4:58 AM, Matt Sicker <boa...@gmail.com> > wrote: > > > > > > > >> Removed all those references in configuration.xml.vm, appenders.xml, > > and > > > >> filters.xml. > > > >> > > > >> > > > >> On 18 July 2014 11:18, Ralph Goers <ralph.go...@dslextreme.com> > > wrote: > > > >> > > > >> > It would be a good idea to verify it in IntelliJ, Eclipse and > > > NetBeans. > > > >> > > > > >> > Ralph > > > >> > > > > >> > On Jul 18, 2014, at 9:11 AM, Matt Sicker <boa...@gmail.com> > wrote: > > > >> > > > > >> > > Depends on if the IDE is doing anything funky. Starting with > Java > > > 1.6, > > > >> > > annotation processing is enabled by default for any processors > on > > > the > > > >> > > classpath, and log4j-core is certainly required on the classpath > > for > > > >> > > building log4j plugins. I think it should work, but there might > be > > > an > > > >> IDE > > > >> > > setting to enable it. > > > >> > > > > > >> > > > > > >> > > On 18 July 2014 11:02, Remko Popma <remko.po...@gmail.com> > wrote: > > > >> > > > > > >> > >> The manual still has a few places where the packages attribute > > for > > > >> > custom > > > >> > >> plugins is mentioned: > > > >> > >> * Configuration > Configuration with XML (both in the table and > > in > > > >> the > > > >> > >> strict XML example) > > > >> > >> * Configuration > Configuration with Jason (the first example > and > > > the > > > >> > >> second (Routing) example) > > > >> > >> * Configuration > Configuring Filters (the example) > > > >> > >> * Configuration > Property Substitution (the example) > > > >> > >> * Configuration > Status Messages (the example) > > > >> > >> * Appenders > (most examples) > > > >> > >> * Filters > (most examples) > > > >> > >> > > > >> > >> If this attribute no longer works we should probably remove all > > > >> > references. > > > >> > >> We should also mention in the release notes that this mechanism > > no > > > >> > longer > > > >> > >> works and users need to rebuild their custom plugins in order > to > > > use > > > >> > them > > > >> > >> with log4j-2.0. > > > >> > >> > > > >> > >> One concern: if I let my IDE do the compilation for my custom > > > plugin, > > > >> > and I > > > >> > >> create a jar by using my IDE's "Export Jar" function, will this > > jar > > > >> file > > > >> > >> include the plugin metadata file? (If not we should warn users > > > about > > > >> > this.) > > > >> > >> > > > >> > >> > > > >> > >> > > > >> > >> > > > >> > >> On Fri, Jul 18, 2014 at 10:38 AM, Matt Sicker < > boa...@gmail.com> > > > >> wrote: > > > >> > >> > > > >> > >>> Alright, I've updated the manual to explain the current plugin > > > >> process. > > > >> > >>> > > > >> > >>> > > > >> > >>> On 17 July 2014 17:17, Jaime Sastre <jsas...@globalavl.com> > > > wrote: > > > >> > >>> > > > >> > >>>> Sorry, I thought 1.5 could compile but services stuff was in > > 1.6, > > > >> > never > > > >> > >>>> mind > > > >> > >>>> > > > >> > >>>> > > > >> > >>>> Sent via Xiaomi > > > >> > >>>> > > > >> > >>>> On Matt Sicker <boa...@gmail.com>, Jul 17, 2014 11:50 PM > > wrote: > > > >> > >>>> What do you mean? You can't compile anything using log4j-core > > in > > > a > > > >> > >>> version > > > >> > >>>> of javac older than 1.6. > > > >> > >>>> > > > >> > >>>> > > > >> > >>>> On 17 July 2014 14:40, Jaime Sastre <jsas...@globalavl.com> > > > wrote: > > > >> > >>>> > > > >> > >>>>> But if you get the wrong versión of javac it wont'be noticed > > > >> > >>>>> > > > >> > >>>>> > > > >> > >>>>> Sent via Xiaomi > > > >> > >>>>> > > > >> > >>>>> On Matt Sicker <boa...@gmail.com>, Jul 17, 2014 9:20 PM > > wrote: > > > >> > >>>>> I'll add some documentation about it. However, the > annotation > > > >> > >> processor > > > >> > >>>>> would work with Ant or even just Make. It's part of javac. > > > >> > >>>>> > > > >> > >>>>> > > > >> > >>>>> On 17 July 2014 13:48, Ralph Goers < > > ralph.go...@dslextreme.com> > > > >> > >> wrote: > > > >> > >>>>> > > > >> > >>>>>> Try looking in the util package. > > > >> > >>>>>> > > > >> > >>>>>> Ralph > > > >> > >>>>>> > > > >> > >>>>>> On Jul 17, 2014, at 9:53 AM, David KOCH <dk...@ezakus.com> > > > >> wrote: > > > >> > >>>>>> > > > >> > >>>>>>> I am getting similiar errors: "error: package > > > >> > >>>>>>> org.apache.logging.log4j.core.helpers does not exist" when > > > >> trying > > > >> > >>> to > > > >> > >>>>>>> compile a custom appender that worked with 2.0-rc1. > > > >> > >>>>>>> > > > >> > >>>>>>> Where was this stuff moved? > > > >> > >>>>>>> > > > >> > >>>>>>> Thanks, > > > >> > >>>>>>> > > > >> > >>>>>>> David > > > >> > >>>>>>> > > > >> > >>>>>>> > > > >> > >>>>>>> On Thu, Jul 17, 2014 at 6:46 PM, Ralph Goers < > > > >> > >>>>> ralph.go...@dslextreme.com > > > >> > >>>>>>> > > > >> > >>>>>>> wrote: > > > >> > >>>>>>> > > > >> > >>>>>>>> Matt, can you update the documentation to reflect these > > > changes > > > >> > >>> and > > > >> > >>>>> tell > > > >> > >>>>>>>> users how to make it work with and without Maven? > > > >> > >>>>>>>> > > > >> > >>>>>>>> Ralph > > > >> > >>>>>>>> > > > >> > >>>>>>>> On Jul 17, 2014, at 8:31 AM, Matt Sicker < > boa...@gmail.com > > > > > > >> > >>> wrote: > > > >> > >>>>>>>> > > > >> > >>>>>>>>> Yeah because it was only used for runtime loading. Now > > that > > > >> > >>>>> log4j-core > > > >> > >>>>>>>>> contains an annotation processor that automatically > > creates > > > >> > >> your > > > >> > >>>>> plugin > > > >> > >>>>>>>>> .dat file, there's no need for the packages attribute. > > It's > > > >> > >>>>> effectively > > > >> > >>>>>>>>> impossible to build a plugin without using log4j-core in > > the > > > >> > >>>>> classpath, > > > >> > >>>>>>>> so > > > >> > >>>>>>>>> it's unnecessary to support the packages attribute. In > > > >> > >>> log4j-core, > > > >> > >>>> I > > > >> > >>>>>> had > > > >> > >>>>>>>> to > > > >> > >>>>>>>>> add some special maven-compiler-plugin settings just to > > get > > > >> > >>>>> log4j-core > > > >> > >>>>>> to > > > >> > >>>>>>>>> use an annotation processor from log4j-core, but other > > > >> projects > > > >> > >>>>> (e.g., > > > >> > >>>>>>>> all > > > >> > >>>>>>>>> the other log4j modules) only need to depend on > log4j-core > > > to > > > >> > >> get > > > >> > >>>>>> loaded > > > >> > >>>>>>>> at > > > >> > >>>>>>>>> runtime. > > > >> > >>>>>>>>> > > > >> > >>>>>>>>> Now if you're using a custom plugin that was built > against > > > an > > > >> > >>> older > > > >> > >>>>>>>> version > > > >> > >>>>>>>>> of log4j, it might not have used the processor at the > > time. > > > >> > >>>>>>>>> > > > >> > >>>>>>>>> > > > >> > >>>>>>>>> On 17 July 2014 10:28, Remko Popma < > remko.po...@gmail.com > > > > > > >> > >>> wrote: > > > >> > >>>>>>>>> > > > >> > >>>>>>>>>> Packages are ignored? > > > >> > >>>>>>>>>> > > > >> > >>>>>>>>>> > > > >> > >>>>>>>>>> On Fri, Jul 18, 2014 at 12:21 AM, Matt Sicker < > > > >> > >> boa...@gmail.com > > > >> > >>>> > > > >> > >>>>>> wrote: > > > >> > >>>>>>>>>> > > > >> > >>>>>>>>>>> The packages attribute is ignored right now. You have > to > > > >> make > > > >> > >>>> sure > > > >> > >>>>>> you > > > >> > >>>>>>>>>>> build your custom plugins using log4j-core in the > > > classpath > > > >> > >>>> (which > > > >> > >>>>> is > > > >> > >>>>>>>>>> sort > > > >> > >>>>>>>>>>> of necessary anyways). Also make sure you haven't > > disabled > > > >> > >>>>> annotation > > > >> > >>>>>>>>>>> processing (it's on by default). > > > >> > >>>>>>>>>>> > > > >> > >>>>>>>>>>> > > > >> > >>>>>>>>>>> On 17 July 2014 07:34, Jaime Sastre < > > > jsas...@globalavl.com> > > > >> > >>>> wrote: > > > >> > >>>>>>>>>>> > > > >> > >>>>>>>>>>>> Yep: > > > >> > >>>>>>>>>>>> <Configuration packages="com.globalavl.commons.log4j" > > > >> > >>>>> status="WARN"> > > > >> > >>>>>>>>>>>> > > > >> > >>>>>>>>>>>> Package is right and and according to > Log4j-config.xsd > > > the > > > >> > >> xml > > > >> > >>>> is > > > >> > >>>>>> fine > > > >> > >>>>>>>>>> as > > > >> > >>>>>>>>>>>> well. > > > >> > >>>>>>>>>>>> I am debugging some log4j code > > > >> > >>>>>>>>>>>> > > > >> > >>>>>>>>>>>> -----Mensaje original----- > > > >> > >>>>>>>>>>>> De: Remko Popma [mailto:remko.po...@gmail.com] > > > >> > >>>>>>>>>>>> Enviado el: jueves, 17 de julio de 2014 13:46 > > > >> > >>>>>>>>>>>> Para: Log4J Users List > > > >> > >>>>>>>>>>>> Asunto: Re: Cannot set up my custom layout in 2.0 > > (worked > > > >> in > > > >> > >>>> rc1) > > > >> > >>>>>>>>>>>> > > > >> > >>>>>>>>>>>> Do you have the correct packages="..." attribute > > > specified > > > >> > >> in > > > >> > >>>> the > > > >> > >>>>>>>>>>>> <Configuration> element? > > > >> > >>>>>>>>>>>> > > > >> > >>>>>>>>>>>> Sent from my iPhone > > > >> > >>>>>>>>>>>> > > > >> > >>>>>>>>>>>>> On 2014/07/17, at 19:08, Jaime Sastre < > > > >> > >> jsas...@globalavl.com > > > >> > >>>> > > > >> > >>>>>> wrote: > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>>> Hi, > > > >> > >>>>>>>>>>>>> Congrats for the release, I been enjoying the > progress > > > of > > > >> > >> it. > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>>> My problema is that I have my layout annotated like > > > this: > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>>> @Plugin(name = "GlobalAVLJSONLayout", category = > > "Core", > > > >> > >>>>>> elementType > > > >> > >>>>>>>>>> = > > > >> > >>>>>>>>>>>>> "layout", printObject = true) public class > > > >> > >>> GlobalAVLJSONLayout > > > >> > >>>>>>>>>> extends > > > >> > >>>>>>>>>>>>> AbstractStringLayout { > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>>> In log4j2.xml: > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>>> <RollingRandomAccessFile > > > >> > >>>>>>>>>>>> name="RollingRandomAccessFile" immediateFlush="false" > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>> fileName="c:/tmp/logs/conf-app.log" > > > >> > >>>>>>>>>>>> > > > >> > >>>>>> > > > >> > >>> > > > >> > filePattern="conf-logs/$${date:yyyy-MM}/app-%d{MM-dd-yyyy}-%i.log.gz"> > > > >> > >>>>>>>>>>>>> > > > >> > >>>> <GlobalAVLJSONLayout > > > >> > >>>>>>>>>>>> source="persistidor" /> > > > >> > >>>>>>>>>>>>> > <Policies> > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>> <TimeBasedTriggeringPolicy /> > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>> <SizeBasedTriggeringPolicy size="100 MB" /> > > > >> > >>>>>>>>>>>>> > </Policies> > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>> <DefaultRolloverStrategy > > > >> > >>>>>>>>>>>> max="5" /> > > > >> > >>>>>>>>>>>>> > </RollingRandomAccessFile> > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>>> It worked with rc1 but with rc2 and 2.0, I am > getting > > > >> this: > > > >> > >>>>>>>>>>>>> 2014-07-17 12:11:20,768 ERROR > RollingRandomAccessFile > > > >> > >>> contains > > > >> > >>>> an > > > >> > >>>>>>>>>>>> invalid element or attribute "GlobalAVLJSONLayout" > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>>> I am not able to find any related change in release > > > notes. > > > >> > >>>>>>>>>>>>> Any help? > > > >> > >>>>>>>>>>>>> Thanks, > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>>> Jaime > > > >> > >>>>>>>>>>>>> > > > >> > >>>>>>>>>>>> > > > >> > >>>>>>>>>>>> > > > >> > >>>>>> > > > >> > >> > > > --------------------------------------------------------------------- > > > >> > >>>>>>>>>>>> To unsubscribe, e-mail: > > > >> > >>>> log4j-user-unsubscr...@logging.apache.org > > > >> > >>>>>>>>>>>> For additional commands, e-mail: > > > >> > >>>>> log4j-user-h...@logging.apache.org > > > >> > >>>>>>>>>>>> > > > >> > >>>>>>>>>>>> > > > >> > >>>>>>>>>>>> > > > >> > >>>>>> > > > >> > >> > > > --------------------------------------------------------------------- > > > >> > >>>>>>>>>>>> To unsubscribe, e-mail: > > > >> > >>>> log4j-user-unsubscr...@logging.apache.org > > > >> > >>>>>>>>>>>> For additional commands, e-mail: > > > >> > >>>>> log4j-user-h...@logging.apache.org > > > >> > >>>>>>>>>>>> > > > >> > >>>>>>>>>>>> > > > >> > >>>>>>>>>>> > > > >> > >>>>>>>>>>> > > > >> > >>>>>>>>>>> -- > > > >> > >>>>>>>>>>> Matt Sicker <boa...@gmail.com> > > > >> > >>>>>>>>>>> > > > >> > >>>>>>>>>> > > > >> > >>>>>>>>> > > > >> > >>>>>>>>> > > > >> > >>>>>>>>> > > > >> > >>>>>>>>> -- > > > >> > >>>>>>>>> Matt Sicker <boa...@gmail.com> > > > >> > >>>>>>>> > > > >> > >>>>>>>> > > > >> > >>>>>>>> > > > >> > >>>> > > > >> > --------------------------------------------------------------------- > > > >> > >>>>>>>> To unsubscribe, e-mail: > > > >> > >> log4j-user-unsubscr...@logging.apache.org > > > >> > >>>>>>>> For additional commands, e-mail: > > > >> > >>> log4j-user-h...@logging.apache.org > > > >> > >>>>>>>> > > > >> > >>>>>>>> > > > >> > >>>>>> > > > >> > >>>>>> > > > >> > >>>>>> > > > >> > >> > > > --------------------------------------------------------------------- > > > >> > >>>>>> To unsubscribe, e-mail: > > > >> log4j-user-unsubscr...@logging.apache.org > > > >> > >>>>>> For additional commands, e-mail: > > > >> > >> log4j-user-h...@logging.apache.org > > > >> > >>>>>> > > > >> > >>>>>> > > > >> > >>>>> > > > >> > >>>>> > > > >> > >>>>> -- > > > >> > >>>>> Matt Sicker <boa...@gmail.com> > > > >> > >>>>> > > > >> > >>>> > > > >> > >>>> > > > >> > >>>> > > > >> > >>>> -- > > > >> > >>>> Matt Sicker <boa...@gmail.com> > > > >> > >>>> > > > >> > >>> > > > >> > >>> > > > >> > >>> > > > >> > >>> -- > > > >> > >>> Matt Sicker <boa...@gmail.com> > > > >> > >>> > > > >> > >> > > > >> > > > > > >> > > > > > >> > > > > > >> > > -- > > > >> > > Matt Sicker <boa...@gmail.com> > > > >> > > > > >> > > > > >> > > > --------------------------------------------------------------------- > > > >> > To unsubscribe, e-mail: log4j-user-unsubscr...@logging.apache.org > > > >> > For additional commands, e-mail: > log4j-user-h...@logging.apache.org > > > >> > > > > >> > > > > >> > > > >> > > > >> -- > > > >> Matt Sicker <boa...@gmail.com> > > > >> > > > > > > > > > > > > > > > > > > > -- > > Matt Sicker <boa...@gmail.com> > > > -- Matt Sicker <boa...@gmail.com>
