[ 
http://issues.apache.org/jira/browse/LOG4NET-34?page=comments#action_12313724 ] 

Ron Grabowski commented on LOG4NET-34:
--------------------------------------

The code actually takes the first text or CDATA. That allows a comment to come 
before the text. 

Another general benefit of being able to use CDATA is that you don't have 
squeeze potentially long marksup all on one line:

<conversionPattern>
 <!-- Hello World -->
<![CDATA[
<header>
 <date>
  <hour>
    %d{h}
  </hour>
 </date>
 <user>
 %u
 </user>
 <info>
 %m
 </info>
</header>
]]> 
</conversionPattern>

I quicklyt tried inserting tabs into the layout using \t, \\t, and '\t' but 
they always rendered as a literal. I didn't see a %tab pattern or a %space{5} 
pattern.

If the text were concatenated, would this appear on one line in the output file?

<conversionPattern>
 <!-- this text is ignored -->
 <![CDATA[%m ]]> 
 <!-- this text is ignored -->
 <![CDATA[%d ]]> 
 <!-- this text is ignored -->
 <![CDATA[%n ]]> 
</conversionPattern>

It looks a little messy but I can think of some cases where it could be useful. 
Especially with describing custom patterns.

> Allow xml config values to be set via XmlNodeType.CDATA or XmlNodeType.Text 
> rather than just value="foo"
> --------------------------------------------------------------------------------------------------------
>
>          Key: LOG4NET-34
>          URL: http://issues.apache.org/jira/browse/LOG4NET-34
>      Project: Log4net
>         Type: Improvement
>     Reporter: Ron Grabowski
>     Priority: Trivial
>  Attachments: XmlHierarchyConfigurator.cs.patch
>
> Currently values for xml config nodes must be passed in via the value 
> attribute:
>  <conversionPattern value="%5p %d{yyyy-MM-dd hh:mm:ss tt} (%c:%L) - %m%n" />
> Why isn't this syntax supported?
>  <conversionPattern>%5p %d{yyyy-MM-dd hh:mm:ss tt} (%c:%L) - 
> %m%n</conversionPattern>
> If the above syntax were supported, a possible solution to this question:
>  http://www.mail-archive.com/log4net-user%40logging.apache.org/msg01791.html
> would be:
>  <conversionPattern>
>   <![CDATA[<header>%n <date>%d</date>%n <user>%u</user>%n 
> <info>%m</info>%n</header>%n]]>
>  </conversionPattern>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to