[
https://issues.apache.org/jira/browse/LOG4NET-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920981#action_12920981
]
Lanchon commented on LOG4NET-59:
--------------------------------
Ron,
assuming the reported bug is real (i've never used a LOG4NET version newer than
1.2.9), the "LOG4NET-59-LastWriteTime.patch" uses a switch-on-type strategy to
workaround the issue that is unacceptable for release:
+ if (this.DateTimeStrategy is
UniversalDateTime)
+ //...
+ else
+ //...
when i submitted the first patch i used a "DateTime AdjustTimeZone(DateTime
localTime)" instead of a getCurrentTime()-style function for a reason: the
previous code was a bit of a mess, major surgery was required for a cleaner
solution which was not warranted (assuming the previous code was well tested).
if your patch was based on code similar to 1.2.9, then there are a few more
things to do than just GetCurrentTime() in the desired timezone. see my diff
file for a guide on other things that needed to be done on 1.2.9. if you need
me i'm available for questions regarding the 1.2.9 era code.
best,
L
> [PATCH] to RollingFileAppender.cs to add the ability to roll files based on
> universal time (UTC).
> -------------------------------------------------------------------------------------------------
>
> Key: LOG4NET-59
> URL: https://issues.apache.org/jira/browse/LOG4NET-59
> Project: Log4net
> Issue Type: New Feature
> Components: Appenders
> Affects Versions: 1.2.9
> Reporter: Lanchon
> Assignee: Ron Grabowski
> Fix For: 1.2.11
>
> Attachments: informative-diff.txt, LOG4NET-59-LastWriteTime.patch,
> Original-1.2.9-beta-RollingFileAppender.cs,
> Patched-1.2.9-beta-RollingFileAppender.cs,
> RollingFileAppender_UniversalDateTime.patch
>
>
> the file naming and rolling time zone is selected via a new property. the
> default value of this property provides backwards compatible bahviour. the
> patch is done on the published 1.2.9beta version. the diff file is only
> informative (not made with the right tool), use original and patched files to
> create a useful diff (accpet my apologies for this). -L
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
