[ 
https://issues.apache.org/jira/browse/LOG4NET-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085066#comment-13085066
 ] 

Curt Arnold commented on LOG4NET-108:
-------------------------------------

The patch file did not apply cleanly for me, perhaps the underlying source has 
changed since the patch was released.

This appears to be an API breaking change since the Evaluator property is 
removed. The number of places the code changes is very high relative to the 
potential value. Adding System.Collections.Generic may impact compatibility.

I'd agree with Nicko and Ron that this is likely better done by providing a 
CompositeTriggeringEventEvaluator that could combine several evaluators and 
combine them to expose the existing interface. That would result in only those 
people who need the feature from flowing through any new code.


> [PATCH] add support for multiple evaluators in BufferingAppenderSkeletan
> ------------------------------------------------------------------------
>
>                 Key: LOG4NET-108
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-108
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Appenders, Core
>    Affects Versions: 1.2.10
>            Reporter: Drew Schaeffer
>            Assignee: Nicko Cadell
>            Priority: Minor
>             Fix For: 1.2.11
>
>         Attachments: EvaluatorCollection.cs, patch-file.diff
>
>
> Currently BufferedAppenders only have support for one evaluator and one lossy 
> evaluator.  This is fine when the only available evaluator is LevelEvaluator 
> (as multriple LevelEvaluators do not make sense) but with the addition of 
> ExceptionEvaluator (LOG4NET-107) it would be nice for 
> BufferingAppenderSkeletan to have a collection of evaluators.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to