On 2011-09-06, Roy Chastain wrote:

> I will take on RFA.  I have had my issues with it and even added a
> different rolling method for my local use.

Great.

I'll likely modify the test case to add tests for the MutexLock (I
suspect it doesn't work as advertized).  The resulting fixes won't touch
RFA but rather FileAppender, though.

> This brings us back to how do I get the current code with any additions
> to start working from.

First pull the current trunk from subversion - there now is a VS2010
solution that targets 4.0 you can start from.  I have also used NUnit's
GUI test runner on the test DLL created by VS and it works OK (I have
some test failures, but some of them happen with NAnt as well).

I don't think there are any patches appended to any of the open JIRA
issues WRT RollingFileAppender so svn is all you have.  In one of the
tickets Ron even mentions major changes in RFA since 1.2.10 so if there
were any patches they likely wouldn't apply anymore anyway.

It is also possible that some of the issues reported against 1.2.10 have
already been fixed by some of the changes Ron mentions.  It is probably
best to start with a test case (we always do that anyway, no ;-).

Once you are done, run "svn diff" in the top level directory and attach
the result as patch to the JIRA ticket.  I'll take care of it from
there.

Stefan

Reply via email to