[ 
https://issues.apache.org/jira/browse/LOG4NET-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103705#comment-13103705
 ] 

Stefan Bodewig commented on LOG4NET-314:
----------------------------------------

Hi Adam, I'm glad you are still around ;-)

I think Lars' threshold would only apply to the %stacktrace part (avoiding the 
cost of grabbing the stack frames unless they are actually needed) while a 
filter would suppress the complete message which might contain additional 
patterns.

> Improve StackTracePatternConverter
> ----------------------------------
>
>                 Key: LOG4NET-314
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-314
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.11
>            Reporter: Stefan Bodewig
>             Fix For: 1.2 Maintenance Release
>
>
> LOG4NET-154 contains a patch that would introduce a MIN-Option to skip a 
> certain number of stack traces that didn't make it into 1.2.11.
> There also is Lars' comment ( 
> https://issues.apache.org/jira/browse/LOG4NET-154?focusedCommentId=12710413&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12710413
>  ) that shows other possible improvements.
> Personally I'm not convinved MIN is the right name for the option in Adam's 
> patch (skip feels more natural but I'm notoriously bad at names).  Also I'd 
> prefer some sort of key-value option string as we expect more improvements 
> and the pipe-syntax likely won't scale.  Something like 
> %stacktrace{frames:3,skip:2,threshold:WARN}.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to