[ 
https://issues.apache.org/jira/browse/LOG4NET-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163649#comment-13163649
 ] 

Roy Chastain commented on LOG4NET-316:
--------------------------------------

Given my somewhat limited knowledge of the log4Net code base and internal 
design, the sub-classing seemed like a simple and clean implementation.  It 
allows for new functionality without adding logic the the PattenLayout base 
class and therefore minimizes the chance of breaking the existing 
implementation.

So, yes other than the fact that I have created a very small class and added to 
class proliferation, I am happy with the sub-classing.
                
> Provide a Layout Pattern that is re-evaluated on each use
> ---------------------------------------------------------
>
>                 Key: LOG4NET-316
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-316
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Other
>    Affects Versions: 1.2.11
>            Reporter: Roy Chastain
>            Priority: Minor
>              Labels: features
>         Attachments: DynamicPatternLayout.cs
>
>
> The DynamicPatternLayout is a layout pattern that is re-evaluated on each 
> use.  It is appropriate to use instead of LayoutPattern to provide dynamic 
> strings in headers and footers for appenders.  Datetime is an example.  Using 
> the standard layout pattern results in the same datetime in each header and 
> footer, while using DynamicPatternLayout results in timestamp of the 
> header/footer creation.
> Example
> <layout type="log4net.Layout.DynamicPatternLayout">
>   <param name="Header" value="%newline**** Trace Opened     Local: 
> %date{yyyy-MM-dd HH:mm:ss.fff}     UTC: %utcdate{yyyy-MM-dd HH:mm:ss.fff} 
> ****%newline"/>
>   <param name="Footer" value="**** Trace Closed %date{yyyy-MM-dd 
> HH:mm:ss.fff} ****%newline"/>
> </layout>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to