[ 
https://issues.apache.org/jira/browse/LOG4NET-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291557#comment-13291557
 ] 

Stefan Bodewig commented on LOG4NET-344:
----------------------------------------

Tom, thanks, your work is very much appreciated.

I need to find more (actually any) time to look into your patch and Ron's code 
to provide a substantial comment.  In any case I agree we should have support 
for this kind of async appending inside log4net itself.
                
> Make AdoNetAppender not to stuck application process
> ----------------------------------------------------
>
>                 Key: LOG4NET-344
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-344
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Appenders
>    Affects Versions: 1.2.10
>         Environment: Windows series
>            Reporter: Tom Tang
>              Labels: patch
>             Fix For: 3.5
>
>         Attachments: AdoNetAppender.cs, AsyncForwardingAppender.cs
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The original AdoNetAppender could stuck application during log insertion.
> Because it use the sync method call to do database insert, once the DB is 
> unavailable or table was locked.
> I change the implementation that has an inner queue inside to store the 
> messages, and the other independent thread will be going to cunsuming the 
> queue messages and do DB insertion.
> This implementation will not have any impact on application performance and 
> much stable.
> Trade off: Once the queue max buffer was full, the later coming log message 
> would be ignored and gone forever. But log4net is not designed for guarantee 
> delivery in purpose, right? So it's not big deal at all. :)  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to